Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change create database api's protobuf definition #3662

Closed
shuiyisong opened this issue Apr 8, 2024 · 2 comments · Fixed by #3682
Closed

Change create database api's protobuf definition #3662

shuiyisong opened this issue Apr 8, 2024 · 2 comments · Fixed by #3682
Assignees
@CookiePieWw
Labels
good first issue Good for newcomers

Comments

@shuiyisong
Copy link
Contributor

What type of enhancement is this?

API improvement

What does the enhancement do?

#3626 (comment)

Change the database_name in CreateDatabaseExpr to schema_name for consistency across the API in greptime-proto. Then update database's code accordingly.

Implementation challenges

No response
@shuiyisong shuiyisong added the good first issue Good for newcomers label Apr 8, 2024
@shuiyisong shuiyisong changed the title Change create database proto api Change create database api's protobuf definition Apr 8, 2024
@CookiePieWw CookiePieWw mentioned this issue Apr 9, 2024
Merged
2 tasks
@CookiePieWw
Copy link
Collaborator

Hi, I've made the change in GreptimeTeam/greptime-proto#143, please take a look. I'll create a pr for database once merged to avoid multiple changes to the commit hash.

@tisonkun
Copy link
Collaborator

tisonkun commented Apr 9, 2024

Cool! Thank you @CookiePieWw !

@CookiePieWw CookiePieWw mentioned this issue Apr 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CookiePieWw CookiePieWw

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: create database api change in protobuf CookiePieWw/greptimedb
3 participants
@tisonkun @CookiePieWw @shuiyisong