Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust index cache page size #5267

Merged
merged 7 commits into from
Jan 3, 2025
Merged

refactor: adjust index cache page size #5267

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd288ef
refactor: adjust index cache page size
CookiePieWw Jan 2, 2025
43b2786
fix: wrong docs
CookiePieWw Jan 2, 2025
481d349
Update config/datanode.example.toml
CookiePieWw Jan 2, 2025
480d4cb
Update config/config.md
CookiePieWw Jan 2, 2025
5a75388
Update config/config.md
CookiePieWw Jan 2, 2025
c695d75
chore: adjust to 64KiB
CookiePieWw Jan 3, 2025
9d20f47
Apply suggestions from code review
CookiePieWw Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
| `region_engine.mito.inverted_index.intermediate_path` | String | `""` | Deprecated, use `region_engine.mito.index.aux_path` instead. |
| `region_engine.mito.inverted_index.metadata_cache_size` | String | `64MiB` | Cache size for inverted index metadata. |
| `region_engine.mito.inverted_index.content_cache_size` | String | `128MiB` | Cache size for inverted index content. |
| `region_engine.mito.inverted_index.content_cache_page_size` | String | `8MiB` | Page size for inverted index content cache. |
| `region_engine.mito.inverted_index.content_cache_page_size` | String | `128KiB` | Page size for inverted index content cache. |
CookiePieWw marked this conversation as resolved.
Show resolved Hide resolved
| `region_engine.mito.fulltext_index` | -- | -- | The options for full-text index in Mito engine. |
| `region_engine.mito.fulltext_index.create_on_flush` | String | `auto` | Whether to create the index on flush.<br/>- `auto`: automatically (default)<br/>- `disable`: never |
| `region_engine.mito.fulltext_index.create_on_compaction` | String | `auto` | Whether to create the index on compaction.<br/>- `auto`: automatically (default)<br/>- `disable`: never |
Expand Down Expand Up @@ -484,8 +484,8 @@
| `region_engine.mito.inverted_index.mem_threshold_on_create` | String | `auto` | Memory threshold for performing an external sort during index creation.<br/>- `auto`: automatically determine the threshold based on the system memory size (default)<br/>- `unlimited`: no memory limit<br/>- `[size]` e.g. `64MB`: fixed memory threshold |
| `region_engine.mito.inverted_index.intermediate_path` | String | `""` | Deprecated, use `region_engine.mito.index.aux_path` instead. |
| `region_engine.mito.inverted_index.metadata_cache_size` | String | `64MiB` | Cache size for inverted index metadata. |
| `region_engine.mito.inverted_index.content_cache_size` | String | `128MiB` | Cache size for inverted index content. |
| `region_engine.mito.inverted_index.content_cache_page_size` | String | `8MiB` | Page size for inverted index content cache. |
| `region_engine.mito.inverted_index.content_cache_size` | String | `128MiB` | Cache size for index content. |
CookiePieWw marked this conversation as resolved.
Show resolved Hide resolved
| `region_engine.mito.inverted_index.content_cache_page_size` | String | `128KiB` | Page size for inverted index content cache. |
CookiePieWw marked this conversation as resolved.
Show resolved Hide resolved
| `region_engine.mito.fulltext_index` | -- | -- | The options for full-text index in Mito engine. |
| `region_engine.mito.fulltext_index.create_on_flush` | String | `auto` | Whether to create the index on flush.<br/>- `auto`: automatically (default)<br/>- `disable`: never |
| `region_engine.mito.fulltext_index.create_on_compaction` | String | `auto` | Whether to create the index on compaction.<br/>- `auto`: automatically (default)<br/>- `disable`: never |
Expand Down
4 changes: 2 additions & 2 deletions config/datanode.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,11 @@ intermediate_path = ""
## Cache size for inverted index metadata.
metadata_cache_size = "64MiB"

## Cache size for inverted index content.
## Cache size for index content.
CookiePieWw marked this conversation as resolved.
Show resolved Hide resolved
content_cache_size = "128MiB"

## Page size for inverted index content cache.
content_cache_page_size = "8MiB"
content_cache_page_size = "128KiB"

## The options for full-text index in Mito engine.
[region_engine.mito.fulltext_index]
Expand Down
2 changes: 1 addition & 1 deletion config/standalone.example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ metadata_cache_size = "64MiB"
content_cache_size = "128MiB"

## Page size for inverted index content cache.
content_cache_page_size = "8MiB"
content_cache_page_size = "128KiB"

## The options for full-text index in Mito engine.
[region_engine.mito.fulltext_index]
Expand Down
2 changes: 1 addition & 1 deletion src/mito2/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ impl Default for InvertedIndexConfig {
intermediate_path: String::new(),
metadata_cache_size: ReadableSize::mb(64),
content_cache_size: ReadableSize::mb(128),
content_cache_page_size: ReadableSize::mb(8),
content_cache_page_size: ReadableSize::kb(128),
};

if let Some(sys_memory) = common_config::utils::get_sys_total_memory() {
Expand Down
Loading