Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: better error mechanism is needed #9

Open
yuanbohan opened this issue Dec 12, 2022 · 2 comments
Open

Error: better error mechanism is needed #9

yuanbohan opened this issue Dec 12, 2022 · 2 comments
Assignees
@yuanbohan
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yuanbohan
Copy link
Contributor

yuanbohan commented Dec 12, 2022 •
edited
Loading

Use String in terms of easy coding for now. Chumsky can be a good choice. This should include at least:

  • Parser
  • Lexer
@yuanbohan yuanbohan added the enhancement New feature or request label Dec 12, 2022
@yuanbohan yuanbohan self-assigned this Dec 12, 2022
This was referenced Dec 12, 2022
Merged
Merged
@yuanbohan
Copy link
Contributor Author

ParseError from cfgrammar SHOULD be friendlier to Prometheus users

@vvv
Copy link

vvv commented Apr 19, 2023

See also winnow = toml_edit + combine + nom. chumsky didn't meet their performance and ergonomics criteria. (It still may be a good choice for promql-parser though.)

@yuanbohan yuanbohan added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuanbohan yuanbohan

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvv @yuanbohan