Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug[next]: ConstantFolding after create_global_tmps #1756

Merged
merged 6 commits into from
Nov 30, 2024
Merged

bug[next]: ConstantFolding after create_global_tmps #1756

merged 6 commits into from
Nov 30, 2024

Conversation

SF-N
Copy link
Contributor

@SF-N SF-N commented Nov 28, 2024 •
edited
Loading

create_global_tmps calls domain inference which creates domain unions, i.e., there were many nested minima and maxima.
Now ConstantFolding is done within domain_union to avoid this.

@SF-N SF-N requested a review from tehrengruber November 28, 2024 15:34
tehrengruber
tehrengruber requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@tehrengruber tehrengruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to revert my approval as this likely doesn't work because the domain is stored in the annex which will not be constant folded.

@SF-N SF-N requested a review from tehrengruber November 29, 2024 14:22
@SF-N SF-N merged commit d581060 into GridTools:main Nov 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehrengruber tehrengruber tehrengruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SF-N @tehrengruber