Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[next]: Fix astype for local fields #1761

Merged
merged 20 commits into from
Dec 4, 2024
Merged

bug[next]: Fix astype for local fields #1761

merged 20 commits into from
Dec 4, 2024

Conversation

SF-N
Copy link
Contributor

@SF-N SF-N commented Nov 29, 2024

Now calling _map additionally.

Some dace tests are skipped because they are failing:

  • dace_itir: will probably be deprecated soon?
  • dace_gtir: this feature is missing

@SF-N SF-N requested a review from havogt November 29, 2024 14:57
@edopao
Copy link
Contributor

edopao commented Nov 29, 2024

#1753 will remove the dace_itir backend, and this should solve the first problem. I am in favor of merging #1753, I have added @havogt as reviewer.

I will push a fix for the second problem, in dace_gtir backend.

@SF-N
Copy link
Contributor Author

SF-N commented Nov 29, 2024

I will push a fix for the second problem, in dace_gtir backend.

Thanks @edopao, the test now also passes with dace_gtir.

@edopao
Copy link
Contributor

edopao commented Dec 2, 2024

OK from my side for the dace lowering.

@edopao
Copy link
Contributor

edopao commented Dec 3, 2024

The dace.itir backend has been deleted in main branch, so I have removed the pytest.skip in the new test case.

Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SF-N SF-N merged commit a936761 into GridTools:main Dec 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants