Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sanity v3 (code ready) #31

Open
hacknug opened this issue Aug 10, 2023 · 2 comments
Open

Add support for Sanity v3 (code ready) #31

hacknug opened this issue Aug 10, 2023 · 2 comments

Comments

@hacknug
Copy link

hacknug commented Aug 10, 2023

I have a working version of this plugin for Sanity v3. @Grsmto would you be interested in a PR?

It is basically a fork of @sanity/google-maps-input that swaps the Google Maps bits for Mapbox (I believe this is what you did when you created the plugin after looking at the code for guidance).

It still uses the old mapbox-gl@v1 so users from your plugin (like myself) don't need to consider any of the policy or pricing changes that came with v2. In case someone needs this to be updated we could look into it, I guess.

Let me know what you think and if this is something that could be of use to anyone 👍

Btw, your plugin still works fine for me with v0.0.3 so perhaps if v0.0.4 is not working we could also look into what regression was introduced and ship a fix for users with sanity v2?

@Grsmto
Copy link
Owner

Grsmto commented Aug 10, 2023

Hi @hacknug

I would happily merge a PR since in its current state it seems like the plugin is not working. I haven't been using Sanity in some time now so I'm a bit lost with the state between v2, v3 etc. (same for Mapbox tbh). So yeah happy to test/merge a PR!

@intelligence
Copy link

@hacknug I'm looking to use Mapbox in a project so it would be appreicated if you could supply a working PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants