From d288e12149db77d0c938bd8ad6f66ed07f699ac8 Mon Sep 17 00:00:00 2001 From: Johan Brichau Date: Fri, 22 Sep 2023 19:51:07 +0200 Subject: [PATCH 1/7] CI changes for gsdevkit --- .github/workflows/ci.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 77a2aed7..6a23de3b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,12 @@ name: smalltalkCI -on: [push, pull_request] +on: + push: + pull_request: + branches: + master + schedule: + - cron: "15 2 7 * *" #run job on the 7th day of every month on the 15th minute of the 2nd hour jobs: test: @@ -32,3 +38,9 @@ jobs: uses: codecov/codecov-action@v3 with: name: ${{ matrix.smalltalk }} + - name: Slack Workflow Notification + uses: Gamesight/slack-workflow-status@master + with: + repo_token: ${{secrets.GITHUB_TOKEN}} + slack_webhook_url: ${{secrets.SLACK_DALEHENRICH}} + name: 'action run' From 19b3967518c3689b468340e14931629760c79c14 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Mon, 1 Apr 2024 16:29:32 -0700 Subject: [PATCH 2/7] GRPlatformtest>>writeToFile:withFileNameDo: had incorrect filename --- ...iteToFile.withFileNameDo.st => writeToFile.withFileNameDo..st} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename repository/Grease-Tests-GemStone32-Core.package/GRPlatformTest.extension/instance/{writeToFile.withFileNameDo.st => writeToFile.withFileNameDo..st} (100%) diff --git a/repository/Grease-Tests-GemStone32-Core.package/GRPlatformTest.extension/instance/writeToFile.withFileNameDo.st b/repository/Grease-Tests-GemStone32-Core.package/GRPlatformTest.extension/instance/writeToFile.withFileNameDo..st similarity index 100% rename from repository/Grease-Tests-GemStone32-Core.package/GRPlatformTest.extension/instance/writeToFile.withFileNameDo.st rename to repository/Grease-Tests-GemStone32-Core.package/GRPlatformTest.extension/instance/writeToFile.withFileNameDo..st From d7b88fe7b3dff2d3c69abafa34c1029cd436d060 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Mon, 1 Apr 2024 16:38:49 -0700 Subject: [PATCH 3/7] update the lineup for 3.6.8 and 3.5.8 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6a23de3b..962479a8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, GemStone64-3.7.0, GemStone64-3.6.5, GemStone64-3.5.7, Squeak64-5.3 ] + smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, GemStone64-3.7.0, GemStone64-3.6.8, GemStone64-3.5.8, Squeak64-5.3 ] experimental: [ false ] include: - smalltalk: Pharo64-12 From 2b63a9058f2f90280e107c1720505e785546582a Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Mon, 12 Aug 2024 11:24:22 -0700 Subject: [PATCH 4/7] update to for 3.7.1 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 962479a8..16097806 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, GemStone64-3.7.0, GemStone64-3.6.8, GemStone64-3.5.8, Squeak64-5.3 ] + smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, GemStone64-3.7.0, GemStone64-3.7.1, GemStone64-3.6.8, GemStone64-3.5.8, Squeak64-5.3 ] experimental: [ false ] include: - smalltalk: Pharo64-12 From 12d2cf17a3804376c2f4716a98d8d1c15351c45d Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Mon, 12 Aug 2024 15:57:01 -0700 Subject: [PATCH 5/7] Issue #32: wire out the GRPackageTest>>testPackages test. The test fails in the presence of Seaside since, Seaside doesn't define the 'required methods' anymore --- .../GRPackageTest.class/instance/testPackages.st | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st b/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st index 3c074d00..c0ff7531 100644 --- a/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st +++ b/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st @@ -1,10 +1,15 @@ tests-packages testPackages | packages | + true + ifTrue: [ + "GRPackage appears to no longer be supported" + "https://github.com/GsDevKit/Grease/issues/32" + ^self ]. packages := GRPackage grPackages. self assert: packages notEmpty. packages do: [ :each | self assert: each name notEmpty. self assert: each license notNil. self deny: (each dependencies includes: nil). - self assert: each url notNil ]. \ No newline at end of file + self assert: each url notNil ]. From 02e0f273fc26358da65c5d3b3a139a1bde918619 Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Tue, 13 Aug 2024 08:46:36 -0700 Subject: [PATCH 6/7] With this fix to Seaside (SeasideSt/Seaside#1441), the patch for #32 is no longer necessary ..revert "Issue #32: wire out the GRPackageTest>>testPackages test. The test fails in the presence of Seaside since, Seaside doesn't define the 'required methods' anymore" This reverts commit 12d2cf17a3804376c2f4716a98d8d1c15351c45d. --- .../GRPackageTest.class/instance/testPackages.st | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st b/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st index c0ff7531..3c074d00 100644 --- a/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st +++ b/repository/Grease-Tests-Core.package/GRPackageTest.class/instance/testPackages.st @@ -1,15 +1,10 @@ tests-packages testPackages | packages | - true - ifTrue: [ - "GRPackage appears to no longer be supported" - "https://github.com/GsDevKit/Grease/issues/32" - ^self ]. packages := GRPackage grPackages. self assert: packages notEmpty. packages do: [ :each | self assert: each name notEmpty. self assert: each license notNil. self deny: (each dependencies includes: nil). - self assert: each url notNil ]. + self assert: each url notNil ]. \ No newline at end of file From 1c70803aa874078319b2198a463f3f26ee6de3c6 Mon Sep 17 00:00:00 2001 From: Kurt Kilpela Date: Fri, 16 Aug 2024 09:33:19 -0700 Subject: [PATCH 7/7] #33 Add missing #greaseNext:putAll:startingAt: method --- .../instance/greaseNext.putAll.startingAt..st | 3 +++ .../GRDelegatingStream.extension/properties.json | 3 +++ 2 files changed, 6 insertions(+) create mode 100644 repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/instance/greaseNext.putAll.startingAt..st create mode 100644 repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/properties.json diff --git a/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/instance/greaseNext.putAll.startingAt..st b/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/instance/greaseNext.putAll.startingAt..st new file mode 100644 index 00000000..7ebc0caa --- /dev/null +++ b/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/instance/greaseNext.putAll.startingAt..st @@ -0,0 +1,3 @@ +*grease-gemstone-core +greaseNext: anInteger putAll: aCollection startingAt: startIndex + stream greaseNext: anInteger putAll: aCollection startingAt: startIndex diff --git a/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/properties.json b/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/properties.json new file mode 100644 index 00000000..5ec29ea0 --- /dev/null +++ b/repository/Grease-GemStone-Core.package/GRDelegatingStream.extension/properties.json @@ -0,0 +1,3 @@ +{ + "name" : "GRDelegatingStream" +} \ No newline at end of file