Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont repeat names 6.2.2 #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ckenny
Copy link

@ckenny ckenny commented Feb 28, 2020

This is a feature implementation to allow unique names by not repeating the name directory. Current behavior is resetting index of directory to 0 at the time of container package or class changes.
It is my humble request that you accept it.

Use case: Sometimes, project may get error if names of classes or members repeats though it is in different packages.

Future Enhancement: A Unique Name Generator can be implemented instead of using name-directory.

kcharan added 5 commits February 28, 2020 11:51
(-dontresetmembernaming, -dontresetclassnaming, -dontresetpackagenaming)

(cherry picked from commit dc09fab)
(cherry picked from commit 2b41dce)
(cherry picked from commit 4392e89)
@ckenny
Copy link
Author

ckenny commented Feb 28, 2020

This change-set can serve below feature request,

#191 how can I make difference class name?

@EricLafortune
Copy link
Contributor

Thank you for your pull request. It looks quite clean as a start, although the naming, plugin support, GUI support, documentation and testing would need to be changed or expanded.

Most importantly, can you provide use cases for each of these options? The Spring framework alone seems a bit marginal to warrant increasing the complexity of the already large number of options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants