Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New" status clear logic does not match lanraragi #50

Open
nspitko opened this issue Feb 9, 2025 · 1 comment
Open

"New" status clear logic does not match lanraragi #50

nspitko opened this issue Feb 9, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@nspitko
Copy link

nspitko commented Feb 9, 2025

In the Lanraragi web UI, opening an archive removes the "new" tag

in LRReader, it only appears to get removed when viewing the last page

LRReader's behavior requires you to read through the entire book (including credits pages and possible variant pages/no text versions which may be included) to clear the flag, which makes it kind of bad for the use case of "Show me stuff I haven't looked at".

If LRReader wants to have a better stance than the web UI that's fine, but I think comic rack's model is probably better:

  • If you complete the archive, it's marked as read
  • If you read more than 25% of the archive, it's marked as read
  • If you've read at least 10 pages, it's marked as read

These three checks catch all of the edge cases, like one page archives, small books, long books, etc. and cover the general intent of "I looked at this intentionally" without the overly aggressive behavior of marking them from a misclick.

Best case would be for this to be configurable between the current behavior, the web UI behavior, and the "smart" behavior.

@Guerra24 Guerra24 added the enhancement New feature or request label Feb 9, 2025
@Guerra24
Copy link
Owner

Guerra24 commented Feb 9, 2025

Hello!

Yup, this seems like a better way of handling it. The current logic somewhat matches Ichaival which is the android client but letting the user pick whatever they want is better, specially now that I have options to give to the user 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants