Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why input size is 25 x 6? #19

Open
kjw9899 opened this issue Jul 6, 2023 · 6 comments
Open

Why input size is 25 x 6? #19

kjw9899 opened this issue Jul 6, 2023 · 6 comments

Comments

@kjw9899
Copy link

kjw9899 commented Jul 6, 2023

what a great work!

I'm implementing with your code, but I have a question.

In your paper, Input is orientations in 6D representation of SMPL body model(24 x 6). When I check from debugging, The input shape is 25 x 6.

Which one is right? or What component is added to 24 x 6?

@kjw9899
Copy link
Author

kjw9899 commented Jul 6, 2023

I check that it seems to zero padding.

Can I ask why do this?

@GuyTevet
Copy link
Owner

GuyTevet commented Aug 3, 2023

The last channel is for global translation. Since its dimensions are 3 and not 6 it's zero-padded.

@zhipenggong
Copy link

where is global translation from, it seems to be from the first action2motion joint, but why action2motion switch 0# and 8#?

@GuyTevet
Copy link
Owner

If I remember correctly, this switching shouldn't be in use anymore. root rotation is at [0] and root translation is at [-1] (only the first 3 entries of it)

@zhipenggong
Copy link

The switching seems to be in use:
https://github.com/GuyTevet/MotionCLIP/blob/main/src/datasets/amass.py#L94

@GuyTevet
Copy link
Owner

That's a definition, not a usage, I don't see where this one is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants