Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing stdexpect in Servus buld... #101

Open
Dweller opened this issue May 12, 2021 · 1 comment
Open

Missing stdexpect in Servus buld... #101

Dweller opened this issue May 12, 2021 · 1 comment

Comments

@Dweller
Copy link

Dweller commented May 12, 2021

Fixed by adding <stdexcept.h> into Servus/servus/serializable.h

[sbanks@ys]~/git/ZeroBuf/build% make
Scanning dependencies of target Servus
[  5%] Building CXX object Servus/servus/CMakeFiles/Servus.dir/version.cpp.o
[ 10%] Building CXX object Servus/servus/CMakeFiles/Servus.dir/md5/md5.cc.o
[ 15%] Building CXX object Servus/servus/CMakeFiles/Servus.dir/serializable.cpp.o
In file included from /home/sbanks/git/ZeroBuf/Servus/servus/serializable.cpp:20:
/home/sbanks/git/ZeroBuf/Servus/servus/serializable.h: In member function ‘virtual bool servus::Serializable::_fromBinary(const void*, size_t)’:
/home/sbanks/git/ZeroBuf/Servus/servus/serializable.h:135:20: error: ‘runtime_error’ is not a member of ‘std’
  135 |         throw std::runtime_error("Binary deserialization not implemented");
      |                    ^~~~~~~~~~~~~
/home/sbanks/git/ZeroBuf/Servus/servus/serializable.h:136:5: error: no return statement in function returning non-void [-Werror=return-type]
  136 |     }

@umlaeute
Copy link

umlaeute commented Mar 7, 2023

Hasn't this been fixed with 53bf825?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants