Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for Rails 8.0 #62

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

MichaelWhi
Copy link
Contributor

@MichaelWhi MichaelWhi commented Nov 12, 2024

Updates for Rails 8.0

Tests run after updating sqlite gem in Gemfile.lock:

$ bin/test
DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. (called from <top (required)> at /workspaces/devise-uncommon_password/test/dummy/config/environment.rb:5)
DEPRECATION WARNING: `to_time` will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. (called from <top (required)> at /workspaces/devise-uncommon_password/test/dummy/config/environment.rb:5)
Run options: --seed 62839

# Running:

.......

Finished in 1.477656s, 4.7372 runs/s, 139.4100 assertions/s.
7 runs, 206 assertions, 0 failures, 0 errors, 0 skips

I did not change it in the gemspec, so older versions still work.

(@HCLarsen What are your thoughts about (new) automated tests based on Github Workflows instead of Travis? Maybe using https://github.com/makandra/gemika or something similar? If you think it's a good idea, I could add a PR.)

@HCLarsen
Copy link
Owner

@MichaelWhi I'm not familiar with Github workflows, but Travis cancelled their free options, so this repo has actually been without a CI for a while. I'd be interested to see how that works.

@HCLarsen HCLarsen merged commit aa384fa into HCLarsen:master Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants