New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GWDM 1.1 #16

Merged

calmacx merged 24 commits into master from add/GWDM/1.1

Feb 2, 2024

Collaborator

calmacx commented Nov 2, 2023 •

edited

Loading

Implements suggestions for UKRI cohort descriptions https://hdruk.atlassian.net/wiki/spaces/HDT/pages/2635464705/Cohorts+study+requirements+doc
- physicalSampleAvailability in Coverage is replaced by biologicalsamples
version added to the required fields
populationSize is added to the summary fields
Organisation type added with a name, id, and a rorid (https://ror.org/)
resourceCreator field is replace by an Organisation definition instead of a short title
publisherName and publisherGatewayId fields are replace by an publisher field of type Organisation
tissuesCollection is added to the model


          add model v1.1

60f221a

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/latest/schema.json Outdated Show resolved Hide resolved

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/latest/schema.json Outdated Show resolved Hide resolved


          remove adding omop ids

97c082f

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/v1_1/Coverage.py Show resolved Hide resolved

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/v1_1/Organisation.py Show resolved Hide resolved

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/latest/schema.json Outdated Show resolved Hide resolved

calmacx added 3 commits

November 2, 2023 13:33


          forbid extra

1ba17ac


          dont allow additional properties

c5fb20a


          update ci just for master

b4f6d45

calmacx added Critical Enhancement and removed Critical labels

calmacx commented

View reviewed changes

hdr_schemata/models/GWDM/v1_1/Coverage.py Show resolved Hide resolved

calmacx added 16 commits

November 13, 2023 12:00


          little cleanup

5e134d2


          add a version 2.1.3

4c4f9b0


          Merge branch 'fix/hdruk/2.1.2' into add/GWDM/1.1

ca225cc


          update

aaa02fa


          merging

163b2f3


          add additions for 1.1 for tissue samples

f1dca22


          fix scripts


          remove a latest file

14277cb


          revert a file

ef2d5b4


          remove these latest folders

2bd10d6


          fix merge issues

4b26e8c


          adding in population size

9fba122


          fix lengths for version control

707e830


          more fixes

e6142b4


          make some changes to populationSize

aab12b2


          update GWDM 1.1

269e492


          add datasetSubType

941c8c5

dnhdruk approved these changes

View reviewed changes

BSnelling reviewed

View reviewed changes

docs/GWDM/1.1.md Show resolved Hide resolved

docs/GWDM/1.1.md Outdated Show resolved Hide resolved

hdr_schemata/models/GWDM/1.1/schema.json Show resolved Hide resolved

hdr_schemata/models/GWDM/v1_1/Organisation.py Show resolved Hide resolved

calmacx added 2 commits

February 2, 2024 09:24


          fix for timeLag

9a4f037


          fix markdown

9c4e386

calmacx requested a review from BSnelling

February 2, 2024 09:29

BSnelling approved these changes

View reviewed changes

calmacx merged commit 4082e8e into master

3 checks passed

calmacx deleted the add/GWDM/1.1 branch

February 2, 2024 10:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels