The Log update should be ready to merge in Master branch #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 15, 2019 15:13
…crire dans un fichier .log
…e à partire du niveau Warn
…r selon niveau
…tion messages des logues
…fficher dans la console
|
Bonne utilisation de git (création de la branche, commits avec la référence aux issues et création de la pull request). Tu as bien implémenté les logs (ajout dépendance, création du fichier de config, création des log). Tu aurais pu respecté les conventions de style Java pour la déclaration de ton logger ("LOGGER" et non pas "logger", c'est une constante). Par contre les logger ne sont pas dans des fichiers. Ils sont les trois dans une console... Je t'ai fait un commit avec les changements sur ta branche "log". Nombre de points obtenus : 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check my work and merge.