Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw-h2: handle server closing connection #21

Closed
dimaqq opened this issue Apr 1, 2020 · 1 comment
Closed

raw-h2: handle server closing connection #21

dimaqq opened this issue Apr 1, 2020 · 1 comment

Comments

@dimaqq
Copy link
Contributor

dimaqq commented Apr 1, 2020 •
edited
Loading

Today

Bad error <ConnectionTerminated error_code:ErrorCodes.NO_ERROR, last_stream_id:0, additional_data:7b22726561736f6e223a22426164436572746966>

The hex translates to {"reason":"BadCertif...

To do

  • report connection being closed
  • decode reason in additional data
  • [possibly] treat this as graceful shutdown, when h2 is ready Support graceful connection close python-hyper/h2#1181
  • [possibly] refuse to open new connections with same cert, or
  • [possibly] throttle connection open rate, as not to flood the server
@dimaqq
Copy link
Contributor Author

dimaqq commented Apr 9, 2020

done, except graceful shutdown.

@dimaqq dimaqq closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimaqq