Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten_graph() called too often #60

Open
Risto97 opened this issue Sep 15, 2024 · 0 comments
Open

Flatten_graph() called too often #60

Risto97 opened this issue Sep 15, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@Risto97
Copy link
Contributor

Risto97 commented Sep 15, 2024

Currently flatten_graph() is called every time a property is read from the IP block library.

Simply it is the safest option, as it makes sure that none of the links changed since the last flatten_graph() call.
E.g. in case a new ip_link() call was done.

Although the performance of SoCMake is still good, flatten_graph() is still a big part of the runtime in the configuration stage.
2024-09-15T10:24:34,469254812+02:00

An alternative to explore is that ip_link() can set a property like GRAPH_MODIFIED, which flatten_graph() would clear.
This way flatten_graph() will be done only when there are changes.

@Risto97 Risto97 added the enhancement New feature or request label Sep 15, 2024
@Risto97 Risto97 added this to the 1.0.0 milestone Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant