Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when ip_link() is called on IP defined in different src dir #84

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Risto97
Copy link
Contributor

@Risto97 Risto97 commented Oct 4, 2024

There is a quirk with INTERFACE_LINK_LIBRARIES property described here: https://cmake.org/cmake/help/v3.30/prop_tgt/INTERFACE_LINK_LIBRARIES.html

When an IP is defined in a subdirectory.
If in another SOURCE directory than where IP was defined we do ip_link() linking another IP to that IP, CMake adds a wrapper around INTERFACE_LINK_LIBRARIES, like this:
::@(directory-id);...;::@

Graph traversal function should filter these directory-id elements.
It is safer than modifying INTERFACE_LINK_LIBRARIES itself upon ip_link process, as it is not clear how this mechanism is useful for other generators.

@Risto97 Risto97 mentioned this pull request Oct 4, 2024
@Risto97 Risto97 merged commit 8b4e8d0 into develop Oct 4, 2024
1 check passed
@Risto97 Risto97 deleted the fix_ip_link_diff_srcdir branch October 4, 2024 21:50
@Risto97
Copy link
Contributor Author

Risto97 commented Oct 5, 2024

resolve #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant