Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test for add_analyses function #809

Open
GraemeWatt opened this issue Jul 9, 2024 · 0 comments
Open

tests: add test for add_analyses function #809

GraemeWatt opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
complexity: medium priority: medium type: bug Indicates an unexpected problem or unintended behaviour

Comments

@GraemeWatt
Copy link
Member

I merged PR #808 even though the test coverage decreased by -0.006% since it is within the tolerance of -0.02%. The new uncovered line is:

doc["analyses"].append({'type': 'NUISANCE', 'analysis': landing_page_url,
'filename': os.path.basename(reference.file_location)})

The other lines in add_analyses are tested indirectly, for example, doi_minter_test.py imports ins1748602 that includes a HistFactory file. I couldn't work out an easy way of modifying the existing tests to cover the above line. We could wait until a record is finalised that includes a ProSelecta file, then import it with import_records to cover the above line, but it would be better to add a dedicated test for the add_analyses function that covers all supported analysis types (currently: Rivet, MadAnalysis, HistFactory and NUISANCE).

@GraemeWatt GraemeWatt added type: bug Indicates an unexpected problem or unintended behaviour priority: medium complexity: medium labels Jul 9, 2024
@github-project-automation github-project-automation bot moved this to To do in @HEPData Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium priority: medium type: bug Indicates an unexpected problem or unintended behaviour
Projects
Status: To do
Development

No branches or pull requests

2 participants