pylint: remove 'disable-msg' and fix imports

* Remove 'disable-msg' comments introduced in commit dfa0a89.
* Add empty "__init__.py" file to tests/ directory.
* Add 'math' and 'array' modules to extension-pkg-whitelist in pylintrc.
* test_utilities.py needs to be a relative import after hepdata_lib.
* With these changes, pylint now gives 10.00/10 on my local setup.

hepdata_lib/c_file_reader.py

@@ -1,6 +1,6 @@
 """.C file reader"""
 import io
-from array import array  # pylint: disable-msg=E0611
+from array import array
 from future.utils import raise_from
 from ROOT import TGraph, TGraphErrors
 import hepdata_lib.root_utils as ru

hepdata_lib/helpers.py

@@ -68,7 +68,7 @@ def get_number_precision(value):
     if value == 0 or isinstance(value, str) or np.isnan(value) or np.isinf(value):
         return value
 
-    return math.ceil(math.log10(abs(value)))  # pylint: disable-msg=I1101
+    return math.ceil(math.log10(abs(value)))
 
 
 def relative_round(value, relative_digits):

pylintrc

@@ -3,7 +3,7 @@
 # A comma-separated list of package or module names from where C extensions may
 # be loaded. Extensions are loading into the active Python interpreter and may
 # run arbitrary code
-extension-pkg-whitelist=
+extension-pkg-whitelist=math,array
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.

tests/__init__.py

@@ -0,0 +1 @@
+"""hepdata_lib tests"""

tests/pylintrc

@@ -3,7 +3,7 @@
 # A comma-separated list of package or module names from where C extensions may
 # be loaded. Extensions are loading into the active Python interpreter and may
 # run arbitrary code
-extension-pkg-whitelist=
+extension-pkg-whitelist=array
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.

tests/test_cfilereader.py

@@ -3,7 +3,7 @@
 from unittest import TestCase
 import os
 import numpy as np
-from hepdata_lib.c_file_reader import CFileReader  # pylint: disable-msg=E0401
+from hepdata_lib.c_file_reader import CFileReader
 
 class TestCFileReader(TestCase):
     """Test the CFileReader class."""

tests/test_execute_command.py

@@ -1,7 +1,7 @@
 # !/usr/bin/env python
 """Test execute_command() function."""
 from unittest import TestCase
-from hepdata_lib.helpers import execute_command  # pylint: disable-msg=E0401
+from hepdata_lib.helpers import execute_command
 
 class TestExecuteCommand(TestCase):
     """Test execute_command() function."""

tests/test_helpers.py

@@ -4,10 +4,10 @@
 
 import numpy as np
 
-from hepdata_lib.helpers import relative_round  # pylint: disable-msg=E0401
-from hepdata_lib.helpers import get_number_precision  # pylint: disable-msg=E0401
-from hepdata_lib.helpers import get_value_precision_wrt_reference  # pylint: disable-msg=E0401
-from hepdata_lib.helpers import round_value_and_uncertainty  # pylint: disable-msg=E0401
+from hepdata_lib.helpers import relative_round
+from hepdata_lib.helpers import get_number_precision
+from hepdata_lib.helpers import get_value_precision_wrt_reference
+from hepdata_lib.helpers import round_value_and_uncertainty
 
 
 class TestHelpers(TestCase):

tests/test_output.py

@@ -5,8 +5,8 @@
 import shutil
 import os
 import yaml
-from test_utilities import tmp_directory_name
-from hepdata_lib import Submission, Table, Variable  # pylint: disable-msg=E0401
+from hepdata_lib import Submission, Table, Variable
+from .test_utilities import tmp_directory_name
 
 class TestOutput(TestCase):
     """Test output"""

tests/test_rootfilereader.py

@@ -1,13 +1,13 @@
 #!/usr/bin/env python
 """Test RootFileReader."""
 from unittest import TestCase
-from array import array  # pylint: disable-msg=E0611
+from array import array
 import os
 import ctypes
 import numpy as np
 import ROOT
-from test_utilities import float_compare, tuple_compare, histogram_compare_1d, make_tmp_root_file
-from hepdata_lib.root_utils import RootFileReader  # pylint: disable-msg=E0401
+from hepdata_lib.root_utils import RootFileReader
+from .test_utilities import float_compare, tuple_compare, histogram_compare_1d, make_tmp_root_file
 
 
 class TestRootFileReader(TestCase):

tests/test_submission.py

@@ -5,8 +5,8 @@
 import string
 from unittest import TestCase
 import tarfile
-from test_utilities import tmp_directory_name
-from hepdata_lib import Submission, Table, Variable, Uncertainty  # pylint: disable-msg=E0401
+from hepdata_lib import Submission, Table, Variable, Uncertainty
+from .test_utilities import tmp_directory_name
 
 class TestSubmission(TestCase):
     """Test the Submission class."""

tests/test_table.py

@@ -4,8 +4,8 @@
 import shutil
 from unittest import TestCase
 
-from test_utilities import tmp_directory_name
-from hepdata_lib import Table, Variable, Uncertainty  # pylint: disable-msg=E0401
+from hepdata_lib import Table, Variable, Uncertainty
+from .test_utilities import tmp_directory_name
 
 class TestTable(TestCase):
     """Test the Table class."""

tests/test_uncertainty.py

@@ -2,8 +2,8 @@
 """Test Uncertainty."""
 import random
 from unittest import TestCase
-import test_utilities
-from hepdata_lib import Variable, Uncertainty  # pylint: disable-msg=E0401
+from hepdata_lib import Variable, Uncertainty
+from .test_utilities import float_compare, tuple_compare
 
 
 class TestUncertainty(TestCase):
@@ -32,16 +32,16 @@ def test_scale_values(self):
             testvar.scale_values(factor)
             scaled_values = [factor * x for x in values]
             scaled_uncertainty = [factor * x for x in uncertainty]
-            self.assertTrue(all(test_utilities.float_compare(x, y)
+            self.assertTrue(all(float_compare(x, y)
                                 for x, y in zip(testvar.values, scaled_values)))
-            self.assertTrue(all(test_utilities.float_compare(x, y)
+            self.assertTrue(all(float_compare(x, y)
                                 for x, y in zip(testunc.values, scaled_uncertainty)))
 
             # Check that inverse also works
             testvar.scale_values(1. / factor)
-            self.assertTrue(all(test_utilities.float_compare(x, y)
+            self.assertTrue(all(float_compare(x, y)
                                 for x, y in zip(testvar.values, values)))
-            self.assertTrue(all(test_utilities.float_compare(x, y)
+            self.assertTrue(all(float_compare(x, y)
                                 for x, y in zip(testunc.values, uncertainty)))
 
     def test_set_values_from_intervals(self):
@@ -68,7 +68,7 @@ def test_set_values_from_intervals(self):
         testunc.set_values_from_intervals(intervals, nominal=values)
 
         # Check that both agree
-        self.assertTrue(all((test_utilities.tuple_compare(tup1, tup2)
+        self.assertTrue(all((tuple_compare(tup1, tup2)
                         for tup1, tup2 in zip(testunc.values, refunc.values))))
 
     def test_mixed_uncertainties(self):

tests/test_variable.py

@@ -2,8 +2,8 @@
 """Test Variable."""
 import random
 from unittest import TestCase
-import test_utilities
-from hepdata_lib import Variable, Uncertainty  # pylint: disable-msg=E0401
+from hepdata_lib import Variable, Uncertainty
+from .test_utilities import tuple_compare
 
 
 class TestVariable(TestCase):
@@ -23,12 +23,12 @@ def test_scale_values(self):
             # Check that scaling works
             testvar.scale_values(factor)
             scaled_values = [(factor * x[0], factor * x[1]) for x in values]
-            assert(all(test_utilities.tuple_compare(x, y)
+            assert(all(tuple_compare(x, y)
                        for x, y in zip(testvar.values, scaled_values)))
 
             # Check that inverse also works
             testvar.scale_values(1. / factor)
-            self.assertTrue(all(test_utilities.tuple_compare(x, y)
+            self.assertTrue(all(tuple_compare(x, y)
                                 for x, y in zip(testvar.values, values)))
 
     def test_add_uncertainty(self):