Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize file reading #6

Open
plaplant opened this issue Aug 19, 2020 · 0 comments
Open

Optimize file reading #6

plaplant opened this issue Aug 19, 2020 · 0 comments

Comments

@plaplant
Copy link
Member

We've been noticing that loading data has been very slow for the data notebooks. I think right now, this is primarily due to using the UVData.__add__() method to combine data instead of the much faster UVData.fast_concat(). For now, the change may be as simple as specifying the axis="blt" keyword argument to the current UVData.read() method calls. This change would use the faster method under the hood, without sacrificing the ability to skip bad files.

In the longer term, we probably also want to implement select-on-read for specific cells/tasks (e.g., when plotting auto spectra, we should only read the autos with the ant_str="auto" keyword). If I'm understanding the code in utils.py correctly, we might be reading in all the data for a single night, and then performing various selections. This will become prohibitively expensive very soon, so we should make changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant