Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Pagination component a11y issue #1933

Closed
rylew1 opened this issue May 6, 2024 · 2 comments
Closed

[Task]: Pagination component a11y issue #1933

rylew1 opened this issue May 6, 2024 · 2 comments
Assignees
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@rylew1
Copy link
Contributor

rylew1 commented May 6, 2024

Summary

The ... in the pagination component is a span tag - and you can't have non-li items within a ul (the pagination component is basically a ul list of buttons)

image

Acceptance criteria

  • Either contribute upstream or file a bug with uswds repo
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label May 6, 2024
@rylew1 rylew1 added this to the Search UI - Enhancements and fast follow milestone May 6, 2024
@rylew1 rylew1 moved this from Icebox to Sprint Ready in Simpler.Grants.gov Product Backlog May 6, 2024
@rylew1
Copy link
Contributor Author

rylew1 commented May 7, 2024

Filed a bug on the @trussworks/react-uswds repo: trussworks/react-uswds#2916

Since we're not in a rush to fix this last remaining a11y issue, we have time for them to take a peek to see if they want to fix it the suggested way or not.

@rylew1 rylew1 moved this from Sprint Ready to In Review in Simpler.Grants.gov Product Backlog May 7, 2024
@rylew1 rylew1 self-assigned this May 7, 2024
@rylew1 rylew1 moved this from In Review to Done in Simpler.Grants.gov Product Backlog May 10, 2024
@widal001
Copy link
Collaborator

Beep boop: Automatically closing this issue because it was marked as 'Done' in https://github.com/orgs/HHS/projects/13. This action was performed by a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Development

No branches or pull requests

2 participants