Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for adding a new experiment are not (no longer?) working #667

Closed
tmadlener opened this issue Jul 15, 2024 · 6 comments
Closed

Comments

@tmadlener
Copy link

tmadlener commented Jul 15, 2024

I was trying to follow these instructions to try and setup an event display for a new experiment. Are these still expected to work? I am mainly asking because I ran into a few issues in a few of my attempts. Any inputs / help would be greatly appreciated.

Main reasons for this issue:

  • The instructions still use npm, but phoenix itself seems to have switched to yarn
  • The default angular version one gets nowadays via npm install -g @angular/cli is 18. However, since angular >= 17 defaults seem to have changed and it's necessary to do a ng new my-app --no-standalone --routing true --style scss (do I want the server side rendering here?)
  • Even if I explicitly use angular 16 I run into build issues.

Maybe I am just missing the correct combination of node and angular versions? I am trying this on Ubuntu 22.04 using the following as a base

$ node --version
v20.15.1
$ npm --version
10.7.0

I have also tried with node 18, but without success.

If the instructions are still supposed to work, I can also provide more detailed information about the issues I have run into.

@DraTeots
Copy link
Collaborator

DraTeots commented Jul 15, 2024

ng new my-app --no-standalone --routing true --style scss
  1. It should work with angular 17 as Phoenix uses angular 17
  2. With getting started finished on your side, ng serve same as npm run start will work, but ng build will not. It has much more deep issues and I was not able to make ng build work without severe builder reconfiguration. Don't fall into this trap.

@DraTeots
Copy link
Collaborator

@EdwardMoyse If you would like, I can rewrite this tutorial to use standalone controls and simplify it for newcomers.

@EdwardMoyse
Copy link
Collaborator

That would be fantastic! Please feel free to rewrite it.

@tmadlener
Copy link
Author

I would also really appreciate that and volunteer for testing.

Just for completeness: I got the the example app from angular to run, but things started to fail for me once I tried to added a new component for the experiment. However, that could also just be me being stupid and not knowing enough about angular to fix a few potentially smaller issues or misunderstanding the instructions.

@DraTeots
Copy link
Collaborator

Here is the PR #668

@EdwardMoyse
Copy link
Collaborator

Again, apologies for the long delay, but I think we can close this now (thanks to @DraTeots )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants