Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main update deps #637

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Main update deps #637

merged 8 commits into from
Mar 18, 2024

Conversation

EdwardMoyse
Copy link
Collaborator

This MR updates Phoenix to the latest threejs version (from 0.160 to 0.162):
https://github.com/mrdoob/three.js/releases/tag/r162
(This required a few code changes)

It also tries to work around the following warnings at install time:

➤ YN0002: │ jsroot@npm:7.6.0 doesn't provide jspdf (p97059), requested by svg2pdf.js
➤ YN0060: │ phoenix-ng@workspace:packages/phoenix-ng provides cypress (pf972e) with version 12.17.3, which doesn't satisfy what cypress-plugin-snapshots requests
➤ YN0002: │ root@workspace:. doesn't provide ts-jest (pc27f3), requested by ts-jest-mock-import-meta

For the jsroot one, I'm not sure what I'm doing is right - updating to jsroot to 7.6.0 (which I also wanted to try because of #627) caused compilation errors:

../../node_modules/svg2pdf.js/dist/svg2pdf.es.min.js:29:0-92 - Error: Module not found: Error: Can't resolve 'jspdf' in '/home/emoyse/phoenix/node_modules/svg2pdf.js/dist'
../../node_modules/jsroot/scripts/jspdf.es.min.js:5926:57-76 - Error: Module not found: Error: Can't resolve 'dompurify' in '/home/emoyse/phoenix/node_modules/jsroot/scripts'
../../node_modules/jsroot/scripts/jspdf.es.min.js:10302:49-64 - Error: Module not found: Error: Can't resolve 'canvg' in '/home/emoyse/phoenix/node_modules/jsroot/scripts'

I think this comes because jsroot isn’t declaring its dependencies correctly. I tried adding these as a packageExtensions override, but now we get a warning:

➤ YN0069: │ jsroot ➤ dependencies ➤ svg2pdf.js: This rule seems redundant when applied on the original package; the extension may have been applied upstream.

For the cypress warning, this is because cypress-plugin-snapshots wants 4.X.Y whilst we're on 12.X.Y. I saw that there had been a recent commit to fix this, but no new release, so I changed to download the package from github.

➤ YN0002: │ root@workspace:. doesn't provide ts-jest (pc27f3), requested by ts-jest-mock-import-meta
➤ YN0060: │ phoenix-ng@workspace:packages/phoenix-ng provides cypress (pf972e) with version 12.17.3, which doesn't satisfy what cypress-plugin-snapshots requests
@EdwardMoyse
Copy link
Collaborator Author

This is very confusing - I cannot reproduce these problems locally.

cc @9inpachi in case he has any idea...

This does not happen locally for me, but on github we see:
Error: Cannot find module 'ts-jest'
@EdwardMoyse EdwardMoyse merged commit d289afd into main Mar 18, 2024
1 check passed
@EdwardMoyse
Copy link
Collaborator Author

No idea why it was failing before... but it succeeded now.

@EdwardMoyse EdwardMoyse deleted the main-update-deps branch June 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant