Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates Phoenix to the latest threejs version (from 0.160 to 0.162):
https://github.com/mrdoob/three.js/releases/tag/r162
(This required a few code changes)
It also tries to work around the following warnings at install time:
For the jsroot one, I'm not sure what I'm doing is right - updating to
jsroot
to7.6.0
(which I also wanted to try because of #627) caused compilation errors:I think this comes because
jsroot
isn’t declaring its dependencies correctly. I tried adding these as apackageExtensions
override, but now we get a warning:For the
cypress
warning, this is becausecypress-plugin-snapshots
wants4.X.Y
whilst we're on12.X.Y
. I saw that there had been a recent commit to fix this, but no new release, so I changed to download the package from github.