Fix for data attributes

HTMLGuyLLC · Sep 10, 2019 · e9e5799 · e9e5799
1 parent bb5c434
commit e9e5799
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -232,11 +232,11 @@ $('.social-share').jConfirm({
     ]
 }).on('facebook-share', function(e, data){
     var btn = $(this);
-    var data_attr = btn.data('some_data_attr'); //1
+    var data_attr = data.some_data_attr; //1
     console.log('Sharing to facebook: '+btn.data('url-to-share'));
 }).on('twitter-share', function(e, data){
     var btn = $(this);
-    var data_attr = btn.data('some_data_attr'); //2
+    var data_attr = data.some_data_attr; //2
     console.log('Sharing to twitter: '+btn.data('url-to-share'));
 });
 ```
diff --git a/index.html b/index.html
@@ -349,17 +349,17 @@ <h4>Social Media Sharing:</h4>
                 class:'twitter-btn'
             }
         ]
-    }).on('facebook-share', function(e){
+    }).on('facebook-share', function(e, data){
         var btn = $(this);
-        var data_attr = btn.data('some_data_attr'); //1
+        var data_attr = data.some_data_attr; //1
         var url = 'http://www.facebook.com/sharer.php?u='+btn.data('url-to-share');
         window.open(
           url,
           '_blank'
         );
-    }).on('twitter-share', function(e){
+    }).on('twitter-share', function(e, data){
         var btn = $(this);
-        var data_attr = btn.data('some_data_attr'); //2
+        var data_attr = data.some_data_attr; //2
         var url = 'http://twitter.com/share?text=This%20is%20the%20best!&url='+btn.data('url-to-share');
         window.open(
           url,

diff --git a/jConfirm.js b/jConfirm.js
@@ -272,7 +272,7 @@
                     e.preventDefault();
                     const btn = $(this);
                     //trigger event
-                    helper.dom_wrapped.trigger(btn.data('event'));
+                    helper.dom_wrapped.trigger(btn.data('event'), btn.data());
                     //hide helper
                     helper.hide();
                     //follow href

diff --git a/jConfirm.min.js b/jConfirm.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jconfirm",
-  "version": "4.5.1",
+  "version": "4.5.2",
   "description": "jQuery confirmation tooltip plugin",
   "author": { 
     "name" : "HTMLGuy, LLC",