Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse network configuration from a team.toml #17

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

schmidma
Copy link
Member

@schmidma schmidma commented Oct 11, 2024

This pull request extends the configurable network devices by hostnames and team numbers. The information is parsed from a team.toml in /media/internal/team.toml.

Dependency Management:

Network Configuration Script Rewrite:

  • meta-hulks/recipes-hulks/network-config/network-config/configure_network: Rewrote the network configuration script from shell to Python. This includes:
    • Switching the script from sh to python.
    • Adding detailed docstrings and type hints.
    • Using Python libraries such as pathlib, subprocess, and tomllib for handling file operations and subprocess calls.
    • Defining functions to load configuration, query head ID, find NAO by head ID, compose network configurations, write to files, and set the hostname.

Necessary Version Increase:

Copy link
Contributor

@knoellle knoellle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knoellle knoellle merged commit 36f5d24 into main Oct 23, 2024
2 checks passed
@knoellle knoellle deleted the team-number-toml branch October 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants