Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ProcessedApplicationData with mixins and examine adapter for resume validation #485

Open
waalbert opened this issue Dec 11, 2024 · 0 comments

Comments

@waalbert
Copy link
Contributor

waalbert commented Dec 11, 2024

Continuing from #483 , because of common attributes between each type of application such as submission_time and reviews, these shared attributes can be put into a mixin/parent class.

Because #468 added an adapter in user.py to satisfy mypy, let's also take a look at why an adapter is needed or not needed.

try:
    resume_url = await resume_handler.upload_resume(
        # TODO: reexamine why adapter is needed
        TypeAdapter(
            Union[RawHackerApplicationData, RawMentorApplicationData]
        ).validate_python(raw_application_data),
        resume,
    )
@waalbert waalbert changed the title Simplify ProcessedApplicationData with mixins Simplify ProcessedApplicationData with mixins and look at adapter for resume validation Dec 11, 2024
@waalbert waalbert changed the title Simplify ProcessedApplicationData with mixins and look at adapter for resume validation Simplify ProcessedApplicationData with mixins and examine adapter for resume validation Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant