Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari UI Fixes #532

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Safari UI Fixes #532

merged 8 commits into from
Jan 6, 2025

Conversation

waalbert
Copy link
Contributor

@waalbert waalbert commented Dec 28, 2024

Changes

UI changes for Safari

  • Refactors to use conditional rendering as opposed to hidden and fixes FAQs (transition-duration now working as initially wanted in feature/faq #428 )
  • Fixes application UI such as
    • "Apply as a Hacker" title
    • alignment of pronouns multi-select checkboxes with their labels
    • git_experience slider more visible
    • ensure all blocks in Partners have the same height
  • Also, fixes p cannot be a descendant of p error encountered on FAQs

Handing this off to @noahk004

Closes #507

@waalbert waalbert requested a review from noahk004 December 28, 2024 00:09
Copy link
Contributor

github-actions bot commented Dec 28, 2024

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 944a5f1

@waalbert waalbert requested a review from IanWearsHat January 6, 2025 01:40
@waalbert waalbert merged commit 6b7246e into main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mobile Safari FAQ UI bug
1 participant