You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #516 and following from #519, the different user status are being reorganized for the entire site to reference, not just the Admin site. The duplicate PortalStatus in ApplicantPortal.tsx can be replaced, and it might also help to reorganize some of the Portal components to use switch statements where exhaustiveness can be checked with typescript-eslint's switch-exhaustiveness-check.
There was also a status called RELEASED that was originally added in HackAtUCI/HackUCI-Site#85 but never used. Instead, the release system from #259 made the applicant's decision become their status which was a simple way to not store a separate value for the decision in the user record. Because #514 chose to leave the system the same, then the unused RELEASED status could be removed.
Also noticed the donut chart in ApplicantSummary needs to include the the pre-release statuses (pending and reviewed). Additionally, the Status enum should ideally have values named as PascalCase following the example from the TypeScript reference for Enums.
The text was updated successfully, but these errors were encountered:
Similar to #516 and following from #519, the different user status are being reorganized for the entire site to reference, not just the Admin site. The duplicate
PortalStatus
inApplicantPortal.tsx
can be replaced, and it might also help to reorganize some of the Portal components to useswitch
statements where exhaustiveness can be checked with typescript-eslint's switch-exhaustiveness-check.There was also a status called
RELEASED
that was originally added in HackAtUCI/HackUCI-Site#85 but never used. Instead, the release system from #259 made the applicant's decision become their status which was a simple way to not store a separate value for the decision in the user record. Because #514 chose to leave the system the same, then the unusedRELEASED
status could be removed.Also noticed the donut chart in
ApplicantSummary
needs to include the the pre-release statuses (pending and reviewed). Additionally, theStatus
enum should ideally have values named as PascalCase following the example from the TypeScript reference for Enums.The text was updated successfully, but these errors were encountered: