Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize usage of Status values throughout site #520

Open
taesungh opened this issue Dec 22, 2024 · 0 comments · May be fixed by #583
Open

Reorganize usage of Status values throughout site #520

taesungh opened this issue Dec 22, 2024 · 0 comments · May be fixed by #583
Assignees

Comments

@taesungh
Copy link
Member

taesungh commented Dec 22, 2024

Similar to #516 and following from #519, the different user status are being reorganized for the entire site to reference, not just the Admin site. The duplicate PortalStatus in ApplicantPortal.tsx can be replaced, and it might also help to reorganize some of the Portal components to use switch statements where exhaustiveness can be checked with typescript-eslint's switch-exhaustiveness-check.

There was also a status called RELEASED that was originally added in HackAtUCI/HackUCI-Site#85 but never used. Instead, the release system from #259 made the applicant's decision become their status which was a simple way to not store a separate value for the decision in the user record. Because #514 chose to leave the system the same, then the unused RELEASED status could be removed.

Also noticed the donut chart in ApplicantSummary needs to include the the pre-release statuses (pending and reviewed). Additionally, the Status enum should ideally have values named as PascalCase following the example from the TypeScript reference for Enums.

@jotalis jotalis linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants