Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form links to mentor and volunteer section #49

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

samderanova
Copy link
Contributor

Replace the placeholder links in MentorVolunteer.tsx with the appropriate links.

@samderanova samderanova linked an issue Nov 30, 2023 that may be closed by this pull request
@samderanova samderanova marked this pull request as ready for review November 30, 2023 06:40
Copy link
Contributor

github-actions bot commented Nov 30, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 45a0819

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 45a0819

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use redirects and have named endpoints, e.g. /mentor, /volunteer?

@samderanova samderanova requested a review from taesungh November 30, 2023 07:08
IanWearsHat
IanWearsHat previously approved these changes Nov 30, 2023
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons redirect to the correct links, so it looks good to me!

@samderanova samderanova marked this pull request as draft November 30, 2023 23:22
rileysw
rileysw previously approved these changes Dec 15, 2023
@samderanova samderanova dismissed stale reviews from rileysw and IanWearsHat via 45a0819 December 16, 2023 04:10
@samderanova samderanova force-pushed the update/mentor-and-volunteer-forms branch from 346fa07 to 45a0819 Compare December 16, 2023 04:10
@samderanova samderanova marked this pull request as ready for review December 16, 2023 04:10
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@samderanova samderanova merged commit b35563a into main Dec 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mentor and volunteer form links to mentor and volunteer section
4 participants