From fcaf56586b824763b8f46c58151cb7fc0601053d Mon Sep 17 00:00:00 2001 From: Cyril Joby Date: Mon, 16 Dec 2024 14:34:21 -0800 Subject: [PATCH 1/3] added links to other applications at bottom of page --- .../ApplyConfirmation/ConfirmationDetails.tsx | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx index a61520bf..49986999 100644 --- a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx +++ b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx @@ -15,6 +15,9 @@ export default async function ConfirmationDetails({ roleText, role, }: ConfirmationDetailsProps) { + const otherRoles = ["Hacker", "Mentor", "Volunteer"].filter( + (r) => r !== role, + ); return (

Before Applying

@@ -61,6 +64,24 @@ export default async function ConfirmationDetails({ } isLightVersion /> + +

+ Interested in being a{" "} + + {otherRoles[0]} + {" "} + or{" "} + + {otherRoles[1]} + {" "} + instead? +

); } From 041d5b764ebf357bde908a6b2db370e96efe3c5b Mon Sep 17 00:00:00 2001 From: Cyril Joby Date: Mon, 16 Dec 2024 16:31:14 -0800 Subject: [PATCH 2/3] make not dependent on array indexing --- .../ApplyConfirmation/ConfirmationDetails.tsx | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx index 49986999..07d9b3ff 100644 --- a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx +++ b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx @@ -67,19 +67,17 @@ export default async function ConfirmationDetails({

Interested in being a{" "} - - {otherRoles[0]} - {" "} - or{" "} - - {otherRoles[1]} - {" "} + {otherRoles.map((role, index) => ( + + + {role} + + {index < otherRoles.length - 1 ? " or " : " "} + + ))} instead?

From fd626da06930592b5467901c1c86d44da828025a Mon Sep 17 00:00:00 2001 From: Cyril Joby Date: Tue, 17 Dec 2024 00:09:12 -0800 Subject: [PATCH 3/3] replace standard a tag with next Link --- .../forms/shared/ApplyConfirmation/ConfirmationDetails.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx index 07d9b3ff..ccb545ca 100644 --- a/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx +++ b/apps/site/src/lib/components/forms/shared/ApplyConfirmation/ConfirmationDetails.tsx @@ -1,4 +1,5 @@ import Button from "@/lib/components/Button/Button"; +import Link from "next/link"; interface ConfirmationDetailsProps { isLoggedIn: boolean; @@ -69,12 +70,12 @@ export default async function ConfirmationDetails({ Interested in being a{" "} {otherRoles.map((role, index) => ( - {role} - + {index < otherRoles.length - 1 ? " or " : " "} ))}