Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for reset skintype to default. #178

Open
milosic5 opened this issue Oct 3, 2019 · 9 comments
Open

Method for reset skintype to default. #178

milosic5 opened this issue Oct 3, 2019 · 9 comments
Assignees
Labels

Comments

@milosic5
Copy link

milosic5 commented Oct 3, 2019

Hi there,

if I set DASHBOARD SKIN for example and then change skin to PLAIN_AMP everything is ok,but when I change again to DASHBOARD it holds white background from previous skin.
This is just for example it is also problem with other skin parameters, not just background.

Is there any method for reset skin parameters to default or to clear parameters which previous skin was set?

Thank you in advance.

Sincerely
Milos

dashboard_skin

plain_amp

dashboard_skin_after_plain_amp_skin

@HanSolo
Copy link
Owner

HanSolo commented Oct 3, 2019

Hmm...not really thought about changing skins at runtime but I already have a method to reset the default skin parameters. Will implement something to fix that issue, thx for the hint 👍🏻

@HanSolo HanSolo self-assigned this Oct 3, 2019
@HanSolo HanSolo added the bug label Oct 3, 2019
@milosic5
Copy link
Author

milosic5 commented Oct 3, 2019

Ok, is that reset method (method name?) already in Medusa 11.2 or it would be committed?

@HanSolo
Copy link
Owner

HanSolo commented Oct 3, 2019

Nope not yet, it will be in 11.3

@HanSolo
Copy link
Owner

HanSolo commented Oct 4, 2019

The last commit contains a new public method on the Gauge class which is called reInit(). This method will reset the ui parameters. It will automatically be called when you switch the skin by calling setSkinType(). You could also call this method manually before you set another skin.

@milosic5
Copy link
Author

milosic5 commented Oct 7, 2019

On Maven repository is still 11.2 and I can't see changes in Gauge class.

@HanSolo
Copy link
Owner

HanSolo commented Oct 7, 2019

yep...I did not create a new release yet, so the changes are only in the repo and not on maven central

@milosic5
Copy link
Author

milosic5 commented Oct 7, 2019

Ok, are you planned to increase version soon?

@HanSolo
Copy link
Owner

HanSolo commented Oct 7, 2019

I usually wait before I create a new release to not create a release for every issue

@milosic5
Copy link
Author

milosic5 commented Oct 7, 2019

I understand, so anyway thank you for this commit and we will cooperate in the future for some improvement on your application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants