Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

api.hd.HDBase(Config config) constructor deadlocks #9

Open
hubert-dufourt opened this issue Apr 11, 2017 · 2 comments
Open

api.hd.HDBase(Config config) constructor deadlocks #9

hubert-dufourt opened this issue Apr 11, 2017 · 2 comments

Comments

@hubert-dufourt
Copy link

Hi,

I'm currently running the latest version of your api (4.1.1) and the api.hd.HDBase(Config config) constructor deadlocks with itself. Is that function supposed to be called since the github documentation (I am not aware that there is a more complete one for the Java apikit) doesn't mention it ?

This issues probably stems from the fact that you initialize a PipeInputStream and a PipeOutputStream in the same thread (l. 129/130 of HDBase.java). The JavaDoc of both objects warns the user about that issue.

Thanks in advance and have a nice day,

@elricho
Copy link
Member

elricho commented Apr 12, 2017

Thanks for pointing that out. Odd that we do that. I'll get that fixed. (And add tests - Gah !!).
In the mean time, can you call the constructor with a config filename instead ? Is that an option for you ?
Cheers, Richard.

@hubert-dufourt
Copy link
Author

hubert-dufourt commented Apr 12, 2017

Hi,
Tbh I used to call the constructor with the config filename but I was trying to avoid to put a file containing my company's precious handset-detection credentials on a repository.

The lib doesn't access the config file outside of the constructor ? (currently thinking of encrypting it and only having a clear version only when calling the constructor)

Cheers, Hubert.

Edit: This or the constructor that takes a byte array. It doesn't look like it is affected by the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants