Implement Alt Assets Variable LUS #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `CVAR_ALT_ASSETS` from LUS cvars cmake. Change all pertinent `CVarGetInteger` calls for `CVAR_ALT_ASSETS` to `ResourceManager::IsAltAssetsEnabled`. Implement frame-end toggle of `mAltAssetsEnabled`.
Move prevAltAssets check to end of `Gfx_ProcessGfxCommands`.
Archez
reviewed
May 31, 2024
Archez
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump LUS to
94b755b77c0c0f566686c9d23fa4c15e23473a0c.Remove
CVAR_ALT_ASSETSfrom LUS cvars cmake.Change all pertinent
CVarGetIntegercalls forCVAR_ALT_ASSETStoResourceManager::IsAltAssetsEnabledor "gAltAssets" as appropriate.Implement frame-end toggle of
mAltAssetsEnabled.Build Artifacts