Fix bug in bound variables check; add regression tests #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check only works reliably when all variables are either bound or unifies with a constant, but it sometimes fails to realize that a variable is unified via binary unifiers to a bound variable.
Sometimes a possibly unbound variable ends up being the representative for the set of variables that it unifies with, in which case
subst.get()
just returns the possibly unbound variable.The solution is to 1) expand the set of known bound variables to include all variables in the image of the derived substitution, and 2) apply the substitution to a possibly unbound variable and check if the result is bound if the other checks fail.
There may be a more clever way of doing this which I haven't realized.