Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve handling response from fullnode's /submit_block #90

Open
luislhl opened this issue Jul 26, 2022 · 0 comments
Open

fix: improve handling response from fullnode's /submit_block #90

luislhl opened this issue Jul 26, 2022 · 0 comments

Comments

@luislhl
Copy link
Contributor

luislhl commented Jul 26, 2022

Summary

The /submit_block endpoint in hathor-core can return 200 for errors, with the errors in the response body.

tx-mining-service is relying only in the response status-code to check if something went wrong.

We should make it read the response body when sending requests to /submit_block.

Specifically, we should make sure we treat the case where hathor.manager.HathorManager.submit_block method in hathor-core can return False in the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant