You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
This relies on the print actually happening which I don't think it should. I'd reset this before compilation instead, there's a nice function for that in serverCompilationContext.ml.
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be filled if that print is not happening, but yeah it didn't seem good. I still added it there in the meantime because I didn't find that function, will update
9b3937c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relies on the print actually happening which I don't think it should. I'd reset this before compilation instead, there's a nice function for that in serverCompilationContext.ml.
9b3937c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be filled if that print is not happening, but yeah it didn't seem good. I still added it there in the meantime because I didn't find that function, will update