Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass storage item dupe #1746

Open
abel1502 opened this issue Oct 27, 2024 · 6 comments
Open

Mass storage item dupe #1746

abel1502 opened this issue Oct 27, 2024 · 6 comments

Comments

@abel1502
Copy link
Contributor

If you switch the item stored in a mass storage unit (i.e. left click the filter slot with it) while it's not empty, all the items inside are transformed into the new one. I believe the solution is to forbid changing the item stored in non-empty MSUs.

@HbmMods
Copy link
Owner

HbmMods commented Oct 27, 2024

Can't replicate this since filter slots are already supposed to be locked when the thing is filled.

@abel1502
Copy link
Contributor Author

I can see the check in

//Don't allow for a type change when the thing isn't empty
if(storage.getStockpile() > 0)
return ret;
, but I have once again tested it manually and the item can be changed even when the storage isn't empty. It seems to work reliably and regardless of the kind of MSU. I suspect slotClick simply isn't invoked, since if I place a stack of items into the filter slot, it is retained as a stack despite
if(slot.getHasStack()) {
slot.getStack().stackSize = 1;
}

@HbmMods
Copy link
Owner

HbmMods commented Oct 27, 2024

Wait, are you using the NH version of NEI?

@abel1502
Copy link
Contributor Author

Yes, I am

@HbmMods
Copy link
Owner

HbmMods commented Oct 27, 2024

god dammit not again

@TheChosenIndividual
Copy link

god dammit not again

"Help i accidentally used the NH version of NEI again"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants