Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Overlay" container #112

Open
peasandwell opened this issue Mar 12, 2018 · 2 comments
Open

Create "Overlay" container #112

peasandwell opened this issue Mar 12, 2018 · 2 comments

Comments

@peasandwell
Copy link
Contributor

peasandwell commented Mar 12, 2018

This is related to #111 <TotalsCalendar /> component, the <Overlay /> container will allow its children to be rendered in an overlay. The child component should be positioned in the middle of the screen.

Note note that the overlay can be triggered to open by using a <Button /> component. (see the calendar icon here - https://heathwallace.invisionapp.com/share/ENFXAUAMSQY#/screens/283473387)

See the Totals Calendar for an example of usage - https://heathwallace.invisionapp.com/share/ENFXAUAMSQY#/screens/283473504

For reference, this overlay will be quite functionally similar to the <SettingsDrawer /> component

Input props

  • children: children (either components or HTML) to go inside the container

Output props

  • onClose(): fired when the overlay close button is clicked
@J35P1N
Copy link
Contributor

J35P1N commented Mar 23, 2018

I would like to work on this. My assumption from this (based on the designs) would be that the overlay slightly greys the screen and provides a close button. It then accepts other components inside.

@J35P1N J35P1N self-assigned this Mar 23, 2018
@dan1elhughes
Copy link

Yup, additionally it'd be nice if the fade background could be clickable to call onClose() too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants