Feature/fetch gas price #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan1elhughes
suggested changes
Apr 9, 2018
src/reducers/slices/gasPrice.js
Outdated
|
|
||
| const loadedGasPrice = (gas, { payload }) => payload.gasPrice; | ||
|
|
||
| const gasPriceReducer = createReducer(initialSettings, { |
There was a problem hiding this comment.
Looks like either initialSettings should be a number, or the gasPrice should be stored as a property of the state object
There was a problem hiding this comment.
I've updated the initialSettings to be a number instead.
added 2 commits
April 11, 2018 11:53
ShaunBulbrook
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding in the recommended gas price api to be fetched by the app and displayed in the component
Issues fixed
Fixes #148
Checklist
npm testreturns no warnings or errors.