Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding of small Ethernet frames #12

Open
ackxolotl opened this issue Jul 29, 2019 · 2 comments
Open

Padding of small Ethernet frames #12

ackxolotl opened this issue Jul 29, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ackxolotl
Copy link
Contributor

Small Ethernet frames (i.e. smaller than 42/46 bytes) should perhaps be padded to the minimum frame length:

https://en.wikipedia.org/wiki/Ethernet_frame#Payload

@HeroicKatora HeroicKatora added the bug Something isn't working label Jul 29, 2019
@emmericp
Copy link
Contributor

emmericp commented Aug 6, 2019

Is there any interface that requires the stack to perform the padding?

On a real NIC the driver would be expected to pad the packet (ixy.rs enables padding in hardware)

@HeroicKatora
Copy link
Owner

Me and @ackxolotl talked about that already and reached the same conclusion, ie. that the nic would be expected to pad automatically. However, it could be desirable to make that transformation in the stack similar to checksums. Might want to change the label to enhancement to reflect this.

@HeroicKatora HeroicKatora added enhancement New feature or request and removed bug Something isn't working labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants