Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discontinued data for line charts #118

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: discontinued data for line charts #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/ez-core/src/utils/scale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const scaleDatumValue = <T = string | number>(
) => {
if (domainKey in datum) {
const value = datum[domainKey] as T;
const scaleValue = AnyScale.scale(value as NumberLike) || 0;
const scaleValue = AnyScale.scale(value as NumberLike);
return scaleValue;
}
throw new Error('Domain key does not exist in the supplied data');
Expand Down Expand Up @@ -143,9 +143,11 @@ export const scalePointData = (
xScale: AnyScale,
yScale: AnyScale
): PointDatum[] => {
return data.map(datum => {
return scalePointDatum(datum, xDomainKey, yDomainKey, xScale, yScale);
});
return data
.map(datum => {
return scalePointDatum(datum, xDomainKey, yDomainKey, xScale, yScale);
})
.filter(d => typeof d.x !== undefined && typeof d.y !== 'undefined');
};

export const scaleBubbleData = (
Expand Down
Loading