fix bug in cell-type specific background filtering

HiDiHlabs · Jul 8, 2024 · e8909ec · e8909ec
1 parent 57b99e2
commit e8909ec
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/sainsc/lazykde/_LazyKDE.py b/sainsc/lazykde/_LazyKDE.py
@@ -493,9 +493,9 @@ def _map_celltype_to_value(
                     raise ValueError("'min_cosine' does not contain all celltypes.")
                 idx2threshold = tuple(min_cosine[ct] for ct in self.celltypes)
                 threshold = _map_celltype_to_value(self.celltype_map, idx2threshold)
-                background &= self.cosine_similarity >= threshold
+                background |= self.cosine_similarity <= threshold
             else:
-                background &= self.cosine_similarity >= min_cosine
+                background |= self.cosine_similarity <= min_cosine
 
         if min_assignment is not None:
             if self.assignment_score is None:
@@ -511,9 +511,9 @@ def _map_celltype_to_value(
                     raise ValueError("'min_assignment' does not contain all celltypes.")
                 idx2threshold = tuple(min_assignment[ct] for ct in self.celltypes)
                 threshold = _map_celltype_to_value(self.celltype_map, idx2threshold)
-                background &= self.assignment_score >= threshold
+                background |= self.assignment_score <= threshold
             else:
-                background &= self.assignment_score >= min_assignment
+                background |= self.assignment_score <= min_assignment
 
         self._background = background