Skip to content

Commit

Permalink
Merge pull request #1387 from HicServices/selectiverefresh-ec-del
Browse files Browse the repository at this point in the history
Disable selective refresh for ExtractionConfiguration when it is being deleted
  • Loading branch information
jas88 authored Aug 30, 2022
2 parents f366ba8 + 30edce1 commit 1a22be2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Running RDMP cli without supplying repository connection details (and after deleting `Databases.yaml`) now results in a specific error message instead of null reference [#1346]https://github.com/HicServices/RDMP/issues/1346
- Fixed Pipeline components who run in threaded but call UI methods resulting in unstable UI components [#1357](https://github.com/HicServices/RDMP/issues/1357)
- Fixed deleting an [ExtractionConfiguration] with Selective Refresh enabled not removing it from UI [#1375](https://github.com/HicServices/RDMP/issues/1375)
- YamlRepository now saves LoadModuleAssembly binary content as a `.nupkg` file instead of string yaml [#1351](https://github.com/HicServices/RDMP/issues/1351)
- Fixed Console Gui activator 'Select File' dialog having a confusing title of "Directory" [#1282](https://github.com/HicServices/RDMP/issues/1282)


## [7.0.17] - 2022-08-01

### Added
Expand Down
4 changes: 4 additions & 0 deletions Rdmp.Core/Providers/DataExportChildProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,10 @@ public bool SelectiveRefresh(SelectedDataSets sds)
}
public bool SelectiveRefresh(IExtractionConfiguration ec)
{
// don't try to selectively refresh when deleting
if (!ec.Exists())
return false;

var project = ec.Project;
// update it to the latest state
project.RevertToDatabaseState();
Expand Down

0 comments on commit 1a22be2

Please sign in to comment.