From 79cc8e14dc3dee501ac38b333b240d60d6541b98 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Tue, 20 Feb 2024 18:00:34 +0200 Subject: [PATCH 01/18] init tests matplotlib-tests.yml. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 80 ++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 .github/workflows/matplotlib-tests.yml diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml new file mode 100644 index 0000000000..3fe8db585e --- /dev/null +++ b/.github/workflows/matplotlib-tests.yml @@ -0,0 +1,80 @@ +# Run tests and integration tests on Mac, which are triggered by each master push. +# Currently, Python3.8 is only used as an environment. +# This is mainly for the sake of speed. +name: matplotlib-tests + +on: + pull_request: + paths: + - tests/visualization_tests/matplotlib_tests + - .github/workflows/matplotlib-tests.yml + - optuna/visualization/**.py + push: + paths: + - tests/visualization_tests/matplotlib_tests + - .github/workflows/matplotlib-tests.yml + - optuna/visualization/**.py + +concurrency: + group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.run_number || github.ref }} + cancel-in-progress: true + +jobs: + tests-mac: + runs-on: ubuntu-latest + + # Scheduled Tests are disabled for forks. + if: (github.event_name == 'schedule' && github.repository == 'optuna/optuna') || (github.event_name != 'schedule') + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python3.8 + uses: actions/setup-python@v4 + with: + python-version: 3.8 + + - name: Setup cache + uses: actions/cache@v3 + env: + cache-name: test + with: + path: ~/Library/Caches/pip + key: ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }}-v1 + restore-keys: | + ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }} + + - name: Install + run: | + python -m pip install --upgrade pip + pip install --progress-bar off -U setuptools + # Install minimal dependencies and confirm that `import optuna` is successful. + pip install --progress-bar off . + python -c 'import optuna' + optuna --version + pip install --progress-bar off .[test] + pip install --progress-bar off .[optional] + + - name: Output installed packages + run: | + pip freeze --all + - name: Output dependency tree + run: | + pip install pipdeptree + pipdeptree + + + - name: Scheduled tests + if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }} + run: | + pytest tests -m "not integration" + - name: Tests with Plotly + if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} + run: | + pytest tests/visualization_tests/matplotlib_tests + - name: Tests without Plotly + if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} + run: | + pip uninstall -y plotly + pytest tests/visualization_tests/matplotlib_tests + From 1850373e01bba91968ec02e597881c79d635a8f6 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Tue, 20 Feb 2024 18:03:01 +0200 Subject: [PATCH 02/18] fixed job name. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 3fe8db585e..f6cda8ef69 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -20,7 +20,7 @@ concurrency: cancel-in-progress: true jobs: - tests-mac: + matplotlib-tests: runs-on: ubuntu-latest # Scheduled Tests are disabled for forks. From 968f7c48709af82c0d7644c901bc16f3093b42b7 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Tue, 20 Feb 2024 18:33:35 +0200 Subject: [PATCH 03/18] isolate _create_study function. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .../matplotlib_tests/test_timeline.py | 2 +- tests/visualization_tests/test_timeline.py | 20 +------------- tests/visualization_tests/utils.py | 26 +++++++++++++++++++ 3 files changed, 28 insertions(+), 20 deletions(-) create mode 100644 tests/visualization_tests/utils.py diff --git a/tests/visualization_tests/matplotlib_tests/test_timeline.py b/tests/visualization_tests/matplotlib_tests/test_timeline.py index 1f45e6d7fe..5801e661cb 100644 --- a/tests/visualization_tests/matplotlib_tests/test_timeline.py +++ b/tests/visualization_tests/matplotlib_tests/test_timeline.py @@ -6,7 +6,7 @@ from optuna.trial import TrialState from optuna.visualization.matplotlib._timeline import plot_timeline -from tests.visualization_tests.test_timeline import _create_study +from tests.visualization_tests.utils import _create_study @pytest.mark.parametrize( diff --git a/tests/visualization_tests/test_timeline.py b/tests/visualization_tests/test_timeline.py index 9c0684858a..0d4ee3e259 100644 --- a/tests/visualization_tests/test_timeline.py +++ b/tests/visualization_tests/test_timeline.py @@ -14,25 +14,7 @@ from optuna.visualization._plotly_imports import go from optuna.visualization._timeline import _get_timeline_info from optuna.visualization._timeline import plot_timeline - - -def _create_study( - trial_states_list: list[TrialState], - trial_sys_attrs: dict[str, Any] | None = None, -) -> Study: - study = optuna.create_study() - fmax = float(len(trial_states_list)) - for i, s in enumerate(trial_states_list): - study.add_trial( - optuna.trial.create_trial( - params={"x": float(i)}, - distributions={"x": optuna.distributions.FloatDistribution(-1.0, fmax)}, - value=0.0 if s == TrialState.COMPLETE else None, - state=s, - system_attrs=trial_sys_attrs, - ) - ) - return study +from tests.visualization_tests.utils import _create_study def _create_study_negative_elapsed_time() -> Study: diff --git a/tests/visualization_tests/utils.py b/tests/visualization_tests/utils.py new file mode 100644 index 0000000000..965dec18f7 --- /dev/null +++ b/tests/visualization_tests/utils.py @@ -0,0 +1,26 @@ +from __future__ import annotations + +from typing import Any + +import optuna +from optuna import Study +from optuna.trial import TrialState + + +def _create_study( + trial_states_list: list[TrialState], + trial_sys_attrs: dict[str, Any] | None = None, +) -> Study: + study = optuna.create_study() + fmax = float(len(trial_states_list)) + for i, s in enumerate(trial_states_list): + study.add_trial( + optuna.trial.create_trial( + params={"x": float(i)}, + distributions={"x": optuna.distributions.FloatDistribution(-1.0, fmax)}, + value=0.0 if s == TrialState.COMPLETE else None, + state=s, + system_attrs=trial_sys_attrs, + ) + ) + return study From 1489bbcd899743277a75824615fec09f6acda9bd Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Tue, 20 Feb 2024 18:37:22 +0200 Subject: [PATCH 04/18] fix trigger when tests are changed. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index f6cda8ef69..24d559553e 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -6,12 +6,12 @@ name: matplotlib-tests on: pull_request: paths: - - tests/visualization_tests/matplotlib_tests + - tests/visualization_tests/matplotlib_tests/** - .github/workflows/matplotlib-tests.yml - optuna/visualization/**.py push: paths: - - tests/visualization_tests/matplotlib_tests + - tests/visualization_tests/matplotlib_tests/** - .github/workflows/matplotlib-tests.yml - optuna/visualization/**.py From 5003be0ee53474416a53ebb245b0e3c6f474d703 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Tue, 20 Feb 2024 18:54:00 +0200 Subject: [PATCH 05/18] remove push trigger. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 24d559553e..499ab9bdb3 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -9,11 +9,6 @@ on: - tests/visualization_tests/matplotlib_tests/** - .github/workflows/matplotlib-tests.yml - optuna/visualization/**.py - push: - paths: - - tests/visualization_tests/matplotlib_tests/** - - .github/workflows/matplotlib-tests.yml - - optuna/visualization/**.py concurrency: group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.run_number || github.ref }} From ca1ebc9ef5be6f3ba64adc58dce0eaeeb75c6462 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Wed, 21 Feb 2024 09:07:29 +0200 Subject: [PATCH 06/18] update GA actions version. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 499ab9bdb3..7321f9d089 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -22,15 +22,15 @@ jobs: if: (github.event_name == 'schedule' && github.repository == 'optuna/optuna') || (github.event_name != 'schedule') steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup Python3.8 - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: 3.8 - name: Setup cache - uses: actions/cache@v3 + uses: actions/cache@v4 env: cache-name: test with: From db9a256f1870d94492da13900f60847650bbee90 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Wed, 21 Feb 2024 12:49:39 +0200 Subject: [PATCH 07/18] move _create_study to test_timeline.py from utils.py. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .../matplotlib_tests/test_timeline.py | 2 +- tests/visualization_tests/test_timeline.py | 27 +++++++++++++++++-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/tests/visualization_tests/matplotlib_tests/test_timeline.py b/tests/visualization_tests/matplotlib_tests/test_timeline.py index 5801e661cb..1f45e6d7fe 100644 --- a/tests/visualization_tests/matplotlib_tests/test_timeline.py +++ b/tests/visualization_tests/matplotlib_tests/test_timeline.py @@ -6,7 +6,7 @@ from optuna.trial import TrialState from optuna.visualization.matplotlib._timeline import plot_timeline -from tests.visualization_tests.utils import _create_study +from tests.visualization_tests.test_timeline import _create_study @pytest.mark.parametrize( diff --git a/tests/visualization_tests/test_timeline.py b/tests/visualization_tests/test_timeline.py index 0d4ee3e259..7f23ff2a6c 100644 --- a/tests/visualization_tests/test_timeline.py +++ b/tests/visualization_tests/test_timeline.py @@ -11,10 +11,33 @@ from optuna.samplers._base import _CONSTRAINTS_KEY from optuna.study.study import Study from optuna.trial import TrialState -from optuna.visualization._plotly_imports import go +from optuna.visualization._plotly_imports import _imports as plotly_imports + + +if plotly_imports.is_successful(): + from optuna.visualization._plotly_imports import go + from optuna.visualization._timeline import _get_timeline_info from optuna.visualization._timeline import plot_timeline -from tests.visualization_tests.utils import _create_study + + +def _create_study( + trial_states_list: list[TrialState], + trial_sys_attrs: dict[str, Any] | None = None, +) -> Study: + study = optuna.create_study() + fmax = float(len(trial_states_list)) + for i, s in enumerate(trial_states_list): + study.add_trial( + optuna.trial.create_trial( + params={"x": float(i)}, + distributions={"x": optuna.distributions.FloatDistribution(-1.0, fmax)}, + value=0.0 if s == TrialState.COMPLETE else None, + state=s, + system_attrs=trial_sys_attrs, + ) + ) + return study def _create_study_negative_elapsed_time() -> Study: From 40a731461f334e71ac68407de643fdbba16a3add Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Wed, 21 Feb 2024 12:49:54 +0200 Subject: [PATCH 08/18] remove utils.py. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- tests/visualization_tests/utils.py | 26 -------------------------- 1 file changed, 26 deletions(-) delete mode 100644 tests/visualization_tests/utils.py diff --git a/tests/visualization_tests/utils.py b/tests/visualization_tests/utils.py deleted file mode 100644 index 965dec18f7..0000000000 --- a/tests/visualization_tests/utils.py +++ /dev/null @@ -1,26 +0,0 @@ -from __future__ import annotations - -from typing import Any - -import optuna -from optuna import Study -from optuna.trial import TrialState - - -def _create_study( - trial_states_list: list[TrialState], - trial_sys_attrs: dict[str, Any] | None = None, -) -> Study: - study = optuna.create_study() - fmax = float(len(trial_states_list)) - for i, s in enumerate(trial_states_list): - study.add_trial( - optuna.trial.create_trial( - params={"x": float(i)}, - distributions={"x": optuna.distributions.FloatDistribution(-1.0, fmax)}, - value=0.0 if s == TrialState.COMPLETE else None, - state=s, - system_attrs=trial_sys_attrs, - ) - ) - return study From 0350caa5d98db56306d24115a55c418f32a3031c Mon Sep 17 00:00:00 2001 From: Daniel Avdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:29:49 +0200 Subject: [PATCH 09/18] comments clean up. Co-authored-by: Kento Nozawa --- .github/workflows/matplotlib-tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 7321f9d089..fb27e37c83 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -1,6 +1,3 @@ -# Run tests and integration tests on Mac, which are triggered by each master push. -# Currently, Python3.8 is only used as an environment. -# This is mainly for the sake of speed. name: matplotlib-tests on: From 636526007301df00d8137ad553e30f92f6323a4d Mon Sep 17 00:00:00 2001 From: Daniel Avdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:30:26 +0200 Subject: [PATCH 10/18] Matplotlib-dependent tests exist in tests/visualization_tests/*.py too. Co-authored-by: Kento Nozawa --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index fb27e37c83..38362ece68 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -3,7 +3,7 @@ name: matplotlib-tests on: pull_request: paths: - - tests/visualization_tests/matplotlib_tests/** + - tests/visualization_tests/** - .github/workflows/matplotlib-tests.yml - optuna/visualization/**.py From 88b58e9194033b9834964991b0708920a0655fd7 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:36:56 +0200 Subject: [PATCH 11/18] cache for ubuntu. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 38362ece68..9c3c3f227f 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -31,7 +31,7 @@ jobs: env: cache-name: test with: - path: ~/Library/Caches/pip + path: ~/.cache/pip key: ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }}-v1 restore-keys: | ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }} From d996a6e3983a6cf85cf53889a58f675db5ad7ef9 Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:39:31 +0200 Subject: [PATCH 12/18] revert actions upgrade. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 9c3c3f227f..f31c95f69b 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -19,15 +19,15 @@ jobs: if: (github.event_name == 'schedule' && github.repository == 'optuna/optuna') || (github.event_name != 'schedule') steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v3 - name: Setup Python3.8 - uses: actions/setup-python@v5 + uses: actions/setup-python@v4 with: python-version: 3.8 - name: Setup cache - uses: actions/cache@v4 + uses: actions/cache@v3 env: cache-name: test with: From 961ed64f537a9a75fa72edba8357e5d78d6ea8ad Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:41:07 +0200 Subject: [PATCH 13/18] remove test step with plotly. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index f31c95f69b..01271e75ff 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -60,10 +60,7 @@ jobs: if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }} run: | pytest tests -m "not integration" - - name: Tests with Plotly - if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} - run: | - pytest tests/visualization_tests/matplotlib_tests + - name: Tests without Plotly if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} run: | From c88998b702f3de3761542458a5b11b2b75a41c7a Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 08:42:54 +0200 Subject: [PATCH 14/18] update cache name. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 01271e75ff..2399fa2995 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -29,7 +29,7 @@ jobs: - name: Setup cache uses: actions/cache@v3 env: - cache-name: test + cache-name: test-with-minimum-versions with: path: ~/.cache/pip key: ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }}-v1 From 23c8231782692274af6250b28aa039d38a1bb9fc Mon Sep 17 00:00:00 2001 From: Daniel Avdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:03:25 +0200 Subject: [PATCH 15/18] remove unnecessary step. Co-authored-by: Kento Nozawa --- .github/workflows/matplotlib-tests.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 2399fa2995..9091949ec0 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -56,10 +56,6 @@ jobs: pipdeptree - - name: Scheduled tests - if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }} - run: | - pytest tests -m "not integration" - name: Tests without Plotly if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} From f53a109b4a8662384e1b894bb048d9e20a45ab10 Mon Sep 17 00:00:00 2001 From: Daniel Avdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:04:00 +0200 Subject: [PATCH 16/18] isort workflow. Co-authored-by: Kento Nozawa --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 9091949ec0..5f29674846 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -3,9 +3,9 @@ name: matplotlib-tests on: pull_request: paths: - - tests/visualization_tests/** - .github/workflows/matplotlib-tests.yml - optuna/visualization/**.py + - tests/visualization_tests/** concurrency: group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.run_number || github.ref }} From be7780074c5e07fda2b2c5eb1bd491b96fe68a6d Mon Sep 17 00:00:00 2001 From: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:04:48 +0200 Subject: [PATCH 17/18] rename caching. Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com> --- .github/workflows/matplotlib-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index 5f29674846..cf9695da2d 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -29,7 +29,7 @@ jobs: - name: Setup cache uses: actions/cache@v3 env: - cache-name: test-with-minimum-versions + cache-name: test-matplotlib with: path: ~/.cache/pip key: ${{ runner.os }}-3.8-${{ env.cache-name }}-${{ hashFiles('**/pyproject.toml') }}-v1 From fb8185161e4ba4ebe3d76f79b49c1afedafe610d Mon Sep 17 00:00:00 2001 From: Daniel Avdar <66269169+DanielAvdar@users.noreply.github.com> Date: Fri, 23 Feb 2024 09:54:55 +0200 Subject: [PATCH 18/18] One more thing. Co-authored-by: Kento Nozawa --- .github/workflows/matplotlib-tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/matplotlib-tests.yml b/.github/workflows/matplotlib-tests.yml index cf9695da2d..a69c83e986 100644 --- a/.github/workflows/matplotlib-tests.yml +++ b/.github/workflows/matplotlib-tests.yml @@ -54,9 +54,6 @@ jobs: run: | pip install pipdeptree pipdeptree - - - - name: Tests without Plotly if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }} run: |