Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't uninstall without killing node #3

Open
thany opened this issue Aug 3, 2015 · 3 comments
Open

Can't uninstall without killing node #3

thany opened this issue Aug 3, 2015 · 3 comments

Comments

@thany
Copy link

thany commented Aug 3, 2015

It's not my cup tea, this view of Git, so I uninstall the extension... Turns out that doesn't work:
capture
Nothing in the developer console is added. Just this error message.

This is on Brackets 1.4, Windows 7 x64, and (not sure if you need these) NPM 2.11.2 and Node 0.12.5.

@thany
Copy link
Author

thany commented Aug 3, 2015

I also can't remove the extension manually even after closing Brackets. It's being used by something. Turns out that "something" is node itself. Apparently this extensions starts a server, but never stops it?... It should really stop the server on uninstalling. And perhaps on exiting Brackets, too.

/edit
Yep, after killing Node, I could uninstall the extension.
This probably still needs a fix in the extension too ;)

@Hirse
Copy link
Owner

Hirse commented Aug 3, 2015

To be honest, I have not tried to uninstall it yet as I was so busy getting the installation and startup to work.
But I definitely agree that uninstalling should be supported.
For now, one can either

  • uninstall the extension before opening it
  • uninstall the extension after killing node (or restarting the computer)
  • or after killing the Ungit process manually using Navigate > Kill Ungit

I have actually noticed the fact that node stays open after exiting Brackets, but during a quick search I have not found any Brackets.enExit hooks that I could use to terminate it.

@Hirse Hirse changed the title Can't uninstall Can't uninstall without killing node Aug 3, 2015
@Hirse
Copy link
Owner

Hirse commented Aug 3, 2015

With v0.3.0 I am using child_process.fork to run Ungit which seems to at least exit when Brackets does, so you would be able to remove the folder manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants