Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-multipush: fix devel build, audit fixes #29

Closed
wants to merge 1 commit into from
Closed

git-multipush: fix devel build, audit fixes #29

wants to merge 1 commit into from

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Apr 4, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Does your submission pass brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • Have you built your formula locally prior to submission with brew install <formula>?

Description

Upstream's devel tarball releases don't build; probably due to an issue with the GitHub release packaging method, and it being tested only from cloned repos. This just sticks in a missing release tag.

Upstream issue: gavinbeatty/git-multipush#1

Plus audit fixes.

Closes Homebrew/legacy-homebrew#50530

@apjanke
Copy link
Contributor Author

apjanke commented Apr 4, 2016

Build failed on Mavericks only, failing to check out the commit. Huh?

 GitHub pull request #29 of commit 4fbde56dcb00166465fde5d2bd09263c386c505f, no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on mavericks in workspace /Users/brew/Jenkins/versions/version/mavericks
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/Homebrew/homebrew-core/ # timeout=10
Fetching upstream changes from https://github.com/Homebrew/homebrew-core/
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress https://github.com/Homebrew/homebrew-core/ +refs/pull/*:refs/remotes/origin/pr/*
Checking out Revision 462b0b73ee988969df9d7cf3df926e19c00e1472 (refs/remotes/origin/pr/29/merge)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 462b0b73ee988969df9d7cf3df926e19c00e1472
FATAL: Could not checkout 462b0b73ee988969df9d7cf3df926e19c00e1472
hudson.plugins.git.GitException: Could not checkout 462b0b73ee988969df9d7cf3df926e19c00e1472
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:1992)
    at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
    at 
...

I'm just retrying the build. Maybe it's intermittent flakeage.

@apjanke apjanke added CI-requeued PR has been re-added to the queue and removed CI-requeued PR has been re-added to the queue labels Apr 4, 2016
@apjanke apjanke closed this in 4c32d18 Apr 4, 2016
@apjanke apjanke deleted the git-multipush-devel branch April 4, 2016 06:09
@apjanke
Copy link
Contributor Author

apjanke commented Apr 4, 2016

A simple rerun on Jenkins fixed it. Merged.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant