Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minizip2 2.8.9 (new formula) #44222

Closed
wants to merge 1 commit into from
Closed

minizip2 2.8.9 (new formula) #44222

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

(Test fails with Error: cannot load such file -- test/unit/assertions. Investigating.)

@vszakats vszakats added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 13, 2019
@javian
Copy link
Contributor

javian commented Sep 13, 2019

Lookin at the acknoledgements this code is based on what is labeled as minizip today in the core tap from what I can tell.

@BrewTestBot
Copy link
Member

  • Dependency 'bzip2' may be unnecessary as it is provided by macOS; try to build this formula without it.
  • Dependency 'zlib' may be unnecessary as it is provided by macOS; try to build this formula without it.

@fxcoudert
Copy link
Member

Yes, it is a fork of the original project, released under the same name. Some other distributions have integrated it as minizip2 but that does not really fit with our usually naming scheme.

  • If it were two versions of the same project, then it would simply be minizip, and the older one would be removed or become minizip@1
  • If it's a fork, and it is sufficiently widely used for inclusion, then nmoinvaz-minizip is probably its name.

@vszakats
Copy link
Contributor Author

vszakats commented Sep 13, 2019

@javian Yes, it was originally forked from there, but it's completely rewritten by now, and offers support for AES encryption, LZMA, BZ2, zlib-ng, in-memory operation, volumes and lots more. Plus a retrofitted minizip 1.x compatibility interface.

@vszakats
Copy link
Contributor Author

vszakats commented Sep 13, 2019

I'm not aware of other popular modern forks of the original (and long abandoned) minizip 1.x, so either @2, or the old one renamed to @1 or even to zlib-minizip (as it was and still is embedded as a contrib inside the zlib source tree.) macports settled with minizip2. Other distros under discussion here.

No hard preference though. We may also rename later, when there is a general agreement amongst distros.

@vszakats
Copy link
Contributor Author

@BrewTestBot Test this please.

@vszakats vszakats closed this in dd07f5a Sep 14, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@vszakats vszakats deleted the minizip2 branch March 13, 2020 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants