From 819d12a1e6e77be60946fc250a66a4df3f699f7d Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Fri, 19 Nov 2021 03:36:19 +0800 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: fn ⌃ ⌥ <70830482+FnControlOption@users.noreply.github.com> --- lib/tests/formulae_dependents.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/tests/formulae_dependents.rb b/lib/tests/formulae_dependents.rb index 1839d1e9..76d305cd 100644 --- a/lib/tests/formulae_dependents.rb +++ b/lib/tests/formulae_dependents.rb @@ -176,9 +176,10 @@ def install_dependent(dependent, testable_dependents, args:, build_from_source: dependent, cache_key: "test-bot-link", ) do |dep_dependent, dependency| - Dependency.prune if dependency.build? && !dependency.test? - Dependency.prune if dependency.test? && dep_dependent != dependent - dependency_f = dependency.to_formula + next if !dependency.build? && !dependency.test? + next if dependency.test? && dep_dependent == dependent + + Dependency.prune Dependency.skip if dependency_f.keg_only? end.map(&:to_formula)