Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Clean Up flepicommon Library Call #351

Open
TimothyWillard opened this issue Oct 18, 2024 · 0 comments
Open

[Bug]: Clean Up flepicommon Library Call #351

TimothyWillard opened this issue Oct 18, 2024 · 0 comments
Labels
bug Defects or errors in the code. good first issue Good for newcomers. low priority Low priority. quick issue Short or easy fix. r-flepicommon Relating to the flepicommon R package.

Comments

@TimothyWillard
Copy link
Contributor

Label

bug, good first issue, quick issue

Priority Label

low priority

Describe the bug/issue

The library call to load the flepicommon package is quite verbose and indicates some issues with how the dependencies are setup for that package.

  1. The packages dplyr and magrittr should be moved from depends to imports to avoid attaching those packages.
  2. Explicitly import when and accumulate from purrr over foreach to get rid of the conflicting imports warning message.

To Reproduce

> library(flepicommon)
Loading required package: dplyr

Attaching package: ‘dplyr’

The following objects are masked from ‘package:stats’:

    filter, lag

The following objects are masked from ‘package:base’:

    intersect, setdiff, setequal, union

Loading required package: magrittr
Warning messages:
1: replacing previous import ‘foreach::when’ by ‘purrr::when’ when loading ‘flepicommon’
2: replacing previous import ‘foreach::accumulate’ by ‘purrr::accumulate’ when loading ‘flepicommon’

Environment, if relevant

MacOS 14.6.1, R 4.3.3, Python 3.10.15, conda 24.5.0

@TimothyWillard TimothyWillard added bug Defects or errors in the code. good first issue Good for newcomers. low priority Low priority. quick issue Short or easy fix. labels Oct 18, 2024
@TimothyWillard TimothyWillard added the r-flepicommon Relating to the flepicommon R package. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or errors in the code. good first issue Good for newcomers. low priority Low priority. quick issue Short or easy fix. r-flepicommon Relating to the flepicommon R package.
Projects
None yet
Development

No branches or pull requests

1 participant