Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving readability/consistency of errors/exceptions in gempyor (second batch) #387

Open
wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Improving readability/consistency of errors/exceptions in gempyor (second batch) #387

wants to merge 36 commits into from

Commits on Nov 1, 2024

  1. Improving errors in another set of gempyor files 

    Includes model_info.py, outcomes.py, seeding.py, seir.py, and simulation_component.py (this last one didn't require any edits).
    @emprzy
    emprzy committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f67d3bc View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'HopkinsIDD:main' into gempyor_error_improvments_part2

    @emprzy
    emprzy authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    141a627 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'main' into gempyor_error_improvements_part2

    @emprzy
    emprzy authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1fe2d4b View commit details
    Browse the repository at this point in the history

  2. Applied black linting to this branch

    @emprzy
    emprzy committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    90b3618 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into gempyor_error_improvements_part2

    @emprzy
    emprzy authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1934338 View commit details
    Browse the repository at this point in the history

  4. Updating a RegEx in test_model_info.py

    @emprzy
    emprzy committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a6c3585 View commit details
    Browse the repository at this point in the history

  5. black linting and RegEx alteration

    @emprzy
    emprzy committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e2a87c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Update flepimop/gempyor_pkg/src/gempyor/seir.py 

    Co-authored-by: Timothy Willard <[email protected]>
    @emprzy @TimothyWillard
    emprzy and TimothyWillard authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    17a4f38 View commit details
    Browse the repository at this point in the history

  2. Update flepimop/gempyor_pkg/src/gempyor/seir.py 

    Co-authored-by: Timothy Willard <[email protected]>
    @emprzy @TimothyWillard
    emprzy and TimothyWillard authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3acad12 View commit details
    Browse the repository at this point in the history

  3. Implementing Tim's suggestions!

    @emprzy
    emprzy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    44ccc84 View commit details
    Browse the repository at this point in the history

  4. Regex adjustment

    @emprzy
    emprzy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b32c64e View commit details
    Browse the repository at this point in the history

  5. Regex update

    @emprzy
    emprzy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d844ced View commit details
    Browse the repository at this point in the history

  6. Implementing Tim's suggestions

    @emprzy
    emprzy committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2cbf2ed View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Regex update in test_statistic_class.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a1692a1 View commit details
    Browse the repository at this point in the history

  2. Regex update in test_statistic_class.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    759795f View commit details
    Browse the repository at this point in the history

  3. Regex adjusment in test_random_distribution_sampler.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    df784d5 View commit details
    Browse the repository at this point in the history

  4. Fixing typo in utils.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8ec6c05 View commit details
    Browse the repository at this point in the history

  5. Regex update in test_random_distribution_sampler.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d760ddc View commit details
    Browse the repository at this point in the history

  6. Regex update in test_random_distribution_sampler.py

    @emprzy
    emprzy committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7e19700 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Update utils.py 

    the function `test_raises_not_implemented_error()` in test file `test_read_df.py` on account that it was receiving a `ValueError` when it expected a `NotImplementedError`. I switched the error within `utils.py:read_df()` to be an expected `NotImplementedError`.
    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    452ddbb View commit details
    Browse the repository at this point in the history

  2. Regex update in test_read_df.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    99d2f36 View commit details
    Browse the repository at this point in the history

  3. Regex update in test_read_df.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    47514d5 View commit details
    Browse the repository at this point in the history

  4. Regex update in test_read_df.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    97d3996 View commit details
    Browse the repository at this point in the history

  5. Updating a unit test in test_utils.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    918ebc7 View commit details
    Browse the repository at this point in the history

  6. Regex update in test_utils.py and error type agreement with utils.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    764c4b2 View commit details
    Browse the repository at this point in the history

  7. Regex update in test_write_df.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c1e79c2 View commit details
    Browse the repository at this point in the history

  8. Regex update in test-write_df.py

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4fd1b11 View commit details
    Browse the repository at this point in the history

  9. Removing deprecated style of \ to escape colons

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2e62ae3 View commit details
    Browse the repository at this point in the history

  10. linting with black

    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e5772c7 View commit details
    Browse the repository at this point in the history

  11. Updating steps_source.py and utils.py 

    There were not that many changes in the final batch of error improvements, so I went ahead and lumped them in with batch two.
    @emprzy
    emprzy committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8fe918a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Implementing Carl's suggestions 

    Awaiting regex error kickback to adjust the test files.
    @emprzy
    emprzy committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f7e53a7 View commit details
    Browse the repository at this point in the history

  2. Regex update in test_model_info.py

    @emprzy
    emprzy committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d5fe360 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Regex update in test_model_info.py

    @emprzy
    emprzy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9c6e1f1 View commit details
    Browse the repository at this point in the history

  2. Regex update in test_model_info.py

    @emprzy
    emprzy committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f7c1ad0 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Typo in model_info.py

    @emprzy
    emprzy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ebe2ebc View commit details
    Browse the repository at this point in the history

  2. Using re.escape() to escape non-alphanumeric characters in the regex

    @emprzy
    emprzy committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    57240be View commit details
    Browse the repository at this point in the history